Repository navigation
feature: add validation for helm-charts - #21
Merged
Merged
Conversation
added 2 commits
October 8, 2026 16:52
Check every variant in changed model version YAMLs using the chart release selected by its declared version constraint. Run strict Helm lint, template rendering, and Kubernetes/CRD schema validation with pinned tools and schemas. Add local commands, regression and integration tests, and CI artifacts for rendered manifests and validation logs. Validator changes trigger a full catalog check.
Set progressDeadlineSeconds to 7200 for sglang-tp2-h100 in model versions 1.0.0 and 1.1.0. The startup probe allows 5400 seconds, so the previous 2000-second deadline caused Helm template validation to fail. Update the validation documentation to record the resolved failures.
primowenjoy
force-pushed
the
feat/wyq-1008
branch
from
October 8, 2026 09:26
710f015 to
14ea93d
Compare
Raise model chart pins and constraint minima to sglang 0.8.0 and vllm 0.5.0, the first releases using the canonical Modelsphere API groups. Remove legacy autoscaling.4pd.io and inference.x-k8s.io schemas and regenerate source provenance. Require Modelsphere CRD sources to use .modelsphere.dev while retaining external projects' upstream groups. Update documentation and tests to check rendered API groups, cover the fixed vLLM release, and reject legacy charts and API groups. Validation: all 43 catalog variants, regression tests, integration tests, and the PR-mode site build pass. BREAKING CHANGE: model variants require controllers and CRDs using the .modelsphere.dev groups. Published chart declarations are deliberately updated and need allow_rewrites when publishing the catalog.
Resolve the newest stable sglang >=0.8.0 and vllm >=0.5.0 from a fresh repository snapshot for each validation run, independently of deployment pins. Keep declared releases resolvable above the baseline and provide a declared mode for reproducing deployment compatibility. Record both versions and the package digest in validation artifacts. Validate all 43 catalog variants against sglang 0.8.11 and vllm 0.7.6. Cover future releases, prerelease exclusion, missing releases and both validation modes with unit and released-chart integration tests.
aceforeverd
requested changes
Oct 8, 2026
| chart: | ||
| name: sglang | ||
| version: ">=0.7.1" | ||
| version: ">=0.8.0" |
Contributor
There was a problem hiding this comment.
revert those chart version change. only in-place change of progressDeadlineSeconds is expected
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add validation for helm-charts