Repository navigation
chore(helm): drop the CPU demo model (demo.enabled) - #42
Merged
Merged
Conversation
The Playground lists Model Serving's deployments since modelsphere#39, so a llama.cpp model the chart runs beside console never shows there, and swiss is where models come from. Remove demo-model.yaml, the demo values, its llm backend and the router's fallback to it, its NOTES, the component selector only it used, and its two chart tests. An install that still sets demo.enabled renders without it; the weights PVC is kept (resource-policy: keep). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Quick starts install Console on its own and point at Swiss for models; the install modes, prerequisites, uninstall leftovers and common values lose the demo rows. The design doc's one-command install described a built-in gateway removed in modelsphere#9 and the demo model; it now says what the chart installs. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does and why
demo.enabledinstalled a llama.cpp model (Qwen2.5-0.5B on CPU) beside console and pointed thellmbackend straight at it. Since #39 the Playground lists the deployments in Model Serving, so a model the chart runs outside swiss never shows there; models come from swiss. The option goes:templates/demo-model.yaml(Deployment, Service, PVC), thedemovalues, thellmbackend's demo branch and its "demo and gateway, set one" refusal, the router's fallback to the demo model, the demo part of NOTES, andconsole.componentSelectorLabels, which only the demo used.TestHelmDemoIsTheLLMBackendandTestHelmDemoWithAGatewayIsRefusedgo with it.Upgrade: an install that still sets
demo.enabledrenders without it (the value is ignored). The weights PVC hadhelm.sh/resource-policy: keepand stays until deleted by hand; CHANGELOG says so.Which issue(s) this PR fixes
None (request from the maintainer). Reviewed in imneov#5.
How it was tested
go test ./...(chart tests render the chart with helm),gofmt -l .empty.helm lint --strict helm/console;helm templatewith--set demo.enabled=truerenders no demo object.On the ModelSphere test cluster:
helm upgradewith this chart (--reset-then-reuse-values) deployed revision 28; the release had demo off, and the PVC left by an earlier demo install was deleted by hand.Checks
go test ./...andgofmt -l .is emptynpm run typecheck && npm test && npm run buildinweb/(no web change)helm lint --strict helm/consoleRelease note
🤖 Generated with Claude Code