Skip to content

fix(three-renderer): keep point symbol geometry local for large coordinates#353

Merged
mlightcad merged 1 commit into
mainfrom
fix/point-symbol-large-coordinates
Jun 12, 2026
Merged

fix(three-renderer): keep point symbol geometry local for large coordinates#353
mlightcad merged 1 commit into
mainfrom
fix/point-symbol-large-coordinates

Conversation

@mlightcad

@mlightcad mlightcad commented Jun 12, 2026

Copy link
Copy Markdown
Owner

Summary

  • Point symbols (dot and line-based display modes) now create geometry at the origin instead of baking world coordinates into vertex data
  • World placement is applied via object position on THREE.Points and THREE.LineSegments, consistent with the RTE batch draw policy
  • Batched point symbols pass world offset through addGeometry so large-coordinate drawings render correctly
  • wcsBbox is computed by translating local geometry bounds to world space
  • Added tests covering large-coordinate point symbols in direct and unbatched draw paths

Test plan

  • Open a drawing with points at large world coordinates (e.g. UTM/Easting values) and verify point symbols render at the correct locations
  • Verify point selection and spatial indexing still work for large-coordinate points
  • Run three-renderer tests: pnpm nx test three-renderer --testPathPattern=AcTrPoint

…inates

Point symbols now use origin-local geometry with world placement on object position, matching the RTE batch draw policy and preserving correct wcsBbox at large coordinates.

Co-authored-by: Cursor <cursoragent@cursor.com>
@mlightcad mlightcad self-assigned this Jun 12, 2026
@mlightcad mlightcad added the fix A direct fix for a known issue or regression. label Jun 12, 2026
@mlightcad mlightcad merged commit dfd684d into main Jun 12, 2026
2 checks passed
@mlightcad mlightcad deleted the fix/point-symbol-large-coordinates branch June 12, 2026 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix A direct fix for a known issue or regression.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant