fix(viewer): use pre-transformed WCS bounds for block group spatial indexing#352
Merged
Merged
Conversation
8e50896 to
0febe9e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
box/boxestowcsBbox/wcsChildBoxesacross three-renderer and cad-simple-viewer for clearer WCS semantics.AcTrView2d.handleGroupdouble-transform bug:AcDbRenderingCache.drawalready applies the INSERT matrix viaapplyMatrix, so spatial indexing must use the pre-transformed WCS bounds directly instead of multiplyinggroup.matrixagain.AcTrGroupWcsBboxAssert) and unit tests covering entity/group WCS bbox updates, layout spatial registration, and handleGroup indexing behavior.Test plan
pnpm test -- --testPathPatterns="AcTr(Entity|Group|Line|LineSegments|MText|Point|Polygon|Shape|Image|Layout|View2d)"(60 tests passed)