Skip to content

fix(html-export): read world offset from matrixWorld for nested drawables#350

Merged
mlightcad merged 2 commits into
mainfrom
fix/html-export-nested-world-offset
Jun 12, 2026
Merged

fix(html-export): read world offset from matrixWorld for nested drawables#350
mlightcad merged 2 commits into
mainfrom
fix/html-export-nested-world-offset

Conversation

@mlightcad

@mlightcad mlightcad commented Jun 12, 2026

Copy link
Copy Markdown
Owner

Summary

  • Fix HTML export batch collector to read world-space translation from matrixWorld instead of local object.position, so rebased geometry nested under parent groups (e.g. MTEXT, block placement roots) exports with correct WCS coordinates.
  • Add eadBatchWorldOffset helper in AcExBatchBuffers and use it in AcExSceneBatchCollector.
  • Add unit tests covering nested drawable offsets, batched line origins, and collectBatchesFromObject3D\ rebase behavior.

Test plan

  • Run cad-html-plugin unit tests for AcExRebase and AcExSceneBatchCollector
  • Open a drawing with large coordinates and export to HTML; verify line/entity positions match the viewer
  • Verify HTML export for drawings with nested block-like or MTEXT subtrees still aligns with WCS

…bles

Co-authored-by: Cursor <cursoragent@cursor.com>
…d lines

Co-authored-by: Cursor <cursoragent@cursor.com>
@mlightcad mlightcad self-assigned this Jun 12, 2026
@mlightcad mlightcad added enhancement New feature or request fix A direct fix for a known issue or regression. labels Jun 12, 2026
@mlightcad mlightcad merged commit 08772f4 into main Jun 12, 2026
2 checks passed
@mlightcad mlightcad deleted the fix/html-export-nested-world-offset branch June 12, 2026 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request fix A direct fix for a known issue or regression.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant