Skip to content

fix(viewer): use batch geometry bounds instead of EXTMIN/EXTMAX for open zoom#347

Merged
mlightcad merged 1 commit into
mainfrom
fix/progressive-open-fit-geometry-bounds
Jun 12, 2026
Merged

fix(viewer): use batch geometry bounds instead of EXTMIN/EXTMAX for open zoom#347
mlightcad merged 1 commit into
mainfrom
fix/progressive-open-fit-geometry-bounds

Conversation

@mlightcad

Copy link
Copy Markdown
Owner

Summary

  • Remove provisional zoom from database EXTMIN/EXTMAX at document open; real-world DXFs often carry stale header extents that diverge from rendered geometry.
  • Simplify progressive open fit to always derive framing from batch-converted geometry bounds (incremental fit for large drawings, final fit via zoomToFitDrawing).
  • Drop resolveModelSpaceExtentsBox and related skip-final-fit logic tied to initial extents.

Test plan

  • Open a DXF/DWG with stale or outlier EXTMIN/EXTMAX header values and confirm the view frames rendered geometry, not unrelated coordinates.
  • Open a small drawing with progressiveRendering enabled and verify final zoom-to-fit is correct.
  • Open a large drawing with progressiveRendering enabled and verify incremental framing during conversion, then final fit when complete.
  • Open into paper space with layout limits and confirm layout-based zoom still works.
  • Pan/zoom manually during progressive open and confirm auto-framing stops.

Made with Cursor

…pen zoom

Stale DXF header extents often diverge from rendered geometry; rely on progressive batch-derived bounds and zoomToFitDrawing instead.

Co-authored-by: Cursor <cursoragent@cursor.com>
@mlightcad mlightcad self-assigned this Jun 12, 2026
@mlightcad mlightcad added the enhancement New feature or request label Jun 12, 2026
@mlightcad mlightcad merged commit 94fb674 into main Jun 12, 2026
2 checks passed
@mlightcad mlightcad deleted the fix/progressive-open-fit-geometry-bounds branch June 12, 2026 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant