feat: layer-aware entity display and full geometry HTML export#346
Merged
Conversation
…ry in HTML export Layer visibility now gates entity conversion during viewing for performance, with lazy conversion when layers turn on and a dedicated export path that materializes off-layer entities for HTML snapshots.
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AcTrEntityDisplayControllerto skip entity conversion on off/frozen layers during interactive viewing, with lazy conversion when layers become visible again.ensureEntitiesConvertedForExport()andprepareAcTrView2dForHtmlExport()so HTML export includes full geometry (including off-layer entities) for the exported layer panel.alwaysBatchDrawPolicyandalwaysUnbatchDrawPolicyhelpers in three-renderer, with unit tests for the new display and export paths.Test plan
cad-html-exporter-cliexport path and verify snapshot completeness.AcTrEntityDisplayController.spec.ts,AcApHtmlConvertor.spec.ts,AcTrBatchDrawPolicy.spec.ts.