test: keep the test suite headless - #1425
Merged
Merged
Conversation
Two authorize() tests in tests/cli/test_cli_auth.py did not patch webbrowser.open and launched the system browser. An autouse fixture now stubs it for the whole suite. Fixes #1424 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1425 +/- ##
=======================================
Coverage 91.69% 91.69%
=======================================
Files 49 49
Lines 5152 5152
=======================================
Hits 4724 4724
Misses 428 428 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Two tests in
tests/cli/test_cli_auth.py(test_authorize_raises_on_callback_errorandtest_authorize_raises_when_no_callback_received) calledauth.authorize()without patchingwebbrowser.open, so running the test suite openedhttps://auth.example/authorizein the system browser. The PR adds an autouse fixture intests/conftest.pythat stubswebbrowser.openfor every test. Tests that patch it explicitly, such astest_authorize_success, still take precedence.Related Issue
Fixes #1424
Motivation and Context
Running the test suite should never open a browser tab. The two unpatched tests broke that expectation and could surprise anyone running tests locally or in CI.
How Has This Been Tested?
uv run pytest tests/cli: 74 passed.Screenshots (if appropriate):
N/A
Types of changes
Docs/refactor/test only.
AI Usage Disclosure
Checklist: