includes: guard environ declaration against macro definition#453
Merged
Conversation
Some platforms provide environ as a macro (e.g. NuttX in stdlib.h), where the unconditional declaration fails to compile. unistd.h is already included and prototypes environ on POSIX, so guard the fallback with #ifndef environ.
Owner
|
Thanks. |
FelipeMdeO
added a commit
to FelipeMdeO/nuttx-apps
that referenced
this pull request
Jun 23, 2026
Generate default_options_guard.h at build time instead of committing a copy, inline the NuttX options into localoptions.h (dropping the nuttx_localoptions.h wrapper), and use upstream compat.c usershell functions instead of custom stubs. Bump the pinned Dropbear commit to 54ef47a now that the environ guard is upstream (mkj/dropbear#453) and drop that hunk from patch 0001. Signed-off-by: Felipe Moura <moura.fmo@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some platforms provide environ as a macro (e.g. NuttX in stdlib.h), where the unconditional declaration fails to compile. unistd.h is already included and prototypes environ on POSIX, so guard the fallback with #ifndef environ.