Repository navigation
Conversation
Filter out authoring queue entries with status 'deferred' when checking for duplicate pattern collisions in tools/check-duplicates.py. Deferred items represent intentionally postponed entries and should not trigger false-positive duplicate collision failures during automated repository checks. Update unit tests in tools/check-duplicates-test.py accordingly. Co-authored-by: mjmirza <34001140+mjmirza@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Duplicate Risk Demonstrated & Real Examples
The authoring queue (
docs/AUTHORING-QUEUE.json) contains entries marked with"status": "deferred". For example,Windowing(patterns/24-stream-processing/windowing.md) is deferred due to a recorded human decision regarding overlap withpatterns/13-frontend-ui/virtual-list.md.Failure Mode & Fix
Before this change,
tools/check-duplicates.pyloaded all authoring queue items without filtering deferred entries. Runningtools/check-duplicates.py --checkormake duplicatesflagged the deferred entry as aQUEUE COLLISIONagainst published entries and failed with exit code 1.By filtering out queue items with
status == "deferred"inanalyze_repository(),tools/check-duplicates.pynow aligns withtools/next-batch.py(which already excludes deferred items). Active queue items remain fully checked against published patterns and historical git commit proposals.Verification & Tests
tools/check-duplicates-test.pywithtest_deferred_queue_items_filteredand updated exit code assertions for--checkand--strictmodes.make test,make duplicates-test, andmake duplicates- all test suites pass cleanly.tools/check-pr-security.pyverified clean.Confidence Score
Total Score: 100/100.
PR created automatically by Jules for task 14428019988472388231 started by @mjmirza