Skip to content

Bump json-logic-rb minimum to 0.3 - #175

Open
tylerjroach wants to merge 1 commit into
masterfrom
codex/bump-json-logic-rb-minimum
Open

tylerjroach wants to merge 1 commit into
masterfrom
codex/bump-json-logic-rb-minimum

Conversation

@tylerjroach

Copy link
Copy Markdown
Contributor

Summary

  • Require json-logic-rb 0.3 or newer within the existing pre-1.0 range.
  • Exclude 0.2.x, which overrides Array.wrap globally. The fix shipped in 0.3.0.

Fixes #173.

Verification

  • gem build mixpanel-ruby.gemspec
  • Confirmed ~> 0.3 accepts 0.3.0 and rejects 0.2.x.

The full spec suite requires Ruby 3; this machine has Ruby 2.6.

@tylerjroach
tylerjroach requested a review from a team September 23, 2026 16:29
@greptile-apps

greptile-apps Bot commented Sep 23, 2026

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

The PR appears safe to merge.

Reviews (1) · Last reviewed commit: "Bump json-logic-rb minimum to 0.3"

@codecov

codecov Bot commented Sep 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.28%. Comparing base (ff81cce) to head (2e008ab).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #175   +/-   ##
=======================================
  Coverage   97.28%   97.28%           
=======================================
  Files          16       16           
  Lines         885      885           
=======================================
  Hits          861      861           
  Misses         24       24           
Flag Coverage Δ
openfeature 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@linear-code

linear-code Bot commented Oct 23, 2026

Copy link
Copy Markdown

SDK-162

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stop relying on json-logic-rb

1 participant