Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #229.
Expose the response's HTTP status as an optional
statusCodeon SDK-created errors so callers can choose whether to retry. Keep the existing messages, Error inheritance and success handling. Transport errors are passed through unchanged; this does not add automatic retries.Adds runtime regressions for plain and verbose response errors, plus callback and batch callback type checks. The seven new status assertions fail on master and pass with this change.
Checked on Node 22, 24 and 26: format, lint, full tests/type checks (496 SDK tests and 56 provider tests), and build. Tests use local mocks, with no service credentials or external requests.