Repository navigation
feat: order book rows pre-fill the order form - #20
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Order-book rows no longer execute trades directly. The per-row fill input+button and the shared section 2FA field are gone; instead each row gets a "Fill form" action that drops that price and size into the Place Order form below (as a limit order, with the buy/sell side derived from ask/bid) and scrolls to it. Execution still happens only through the form, which keeps its own 2FA field — one obvious place to review before signing.
Own-order conclusion (with 2FA) is unchanged.