Skip to content

fix: read token logos from the published logo_uri field #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erubboli merged 1 commit into from
Oct 12, 2026
Merged

fix: read token logos from the published logo_uri field #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions app/src/lib/bridge-sdk/token-metadata.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,9 @@ describe('sanitizeTokenMetadata', () => {

it('accepts gateway and same-origin icon URLs, rejects cross-origin protocol-relative', () => {
expect(sanitizeTokenMetadata({ icon: 'ipfs://QmHash' })?.icon).toBe('/ipfs/QmHash');
expect(sanitizeTokenMetadata({ logo_uri: 'ipfs://bafyLogo' })?.icon).toBe(
'/ipfs/bafyLogo',
);
expect(sanitizeTokenMetadata({ icon: 'https://cdn.example/i.png' })?.icon).toBe(
'https://cdn.example/i.png',
);
Expand Down
6 changes: 5 additions & 1 deletion app/src/lib/bridge-sdk/tokenMetadata.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,11 @@ export function sanitizeTokenMetadata(raw: unknown): TokenMetadata | null {
if (decimals !== undefined) metadata.decimals = decimals;

// Same icon fallback chain resolveTokenIcon has always used.
const icon = clipIcon(raw.tokenIcon ?? raw.icon_uri ?? raw.icon ?? raw.image);
// logo_uri: the schema actually published on-chain (e.g. mlUSDC
// metadata) puts the logo there.
const icon = clipIcon(
raw.tokenIcon ?? raw.icon_uri ?? raw.logo_uri ?? raw.icon ?? raw.image,
);
if (icon) metadata.icon = icon;

if (isRecord(raw.origin)) {
Expand Down
Loading