Repository navigation
crypto: re-export order signing types, make parse_addressable public - #5
Merged
Merged
Conversation
Signing an order's fill/conclude/freeze inputs requires the order's balances via TxAdditionalInfo::with_order_info, but the SDK did not re-export OrderId, OrderAdditionalInfo or TokenId, and kept parse_addressable private - so downstream code could not build the additional info without depending on mintlayer-core directly. - re-export OrderAdditionalInfo next to TxAdditionalInfo - re-export OrderId and TokenId from crypto::types - make crypto::parse_addressable public (parse a bech32 address into any Addressable, e.g. an OrderId or TokenId)
|
✅ OpenCodeReview: Review complete: 0 finding(s) across 1 selected item(s). |
Move the TokenId re-export to satisfy rustfmt's import ordering and link the parse_addressable doc comment to types::OrderId, which rustdoc -D warnings could not resolve from the crypto module scope.
nullPointerEnjoyer
approved these changes
Oct 5, 2026
anyxem
approved these changes
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signing an order's fill/conclude/freeze inputs requires the order's balances via
TxAdditionalInfo::with_order_info, but the SDK did not re-exportOrderId,OrderAdditionalInfoorTokenId, and keptparse_addressableprivate (pub(crate)) — so downstream code could not build the additional info for signing a conclude-order input without depending on mintlayer-core directly.OrderAdditionalInfonext toTxAdditionalInfoOrderIdandTokenIdfromcrypto::typescrypto::parse_addressablepublic (parse a bech32 address into anyAddressable, e.g. anOrderIdorTokenId)cargo check --features cryptopasses; a full conclude-and-recreate flow (build conclude input, re-create order output,TxAdditionalInfo, per-input witnesses,encode_signed_transaction,get_order_id) compiles against this branch.