Repository navigation
fix(orders-accounting): show full order ID in overbid errors - #2138
Merged
Merged
Conversation
|
✅ OpenCodeReview: Review complete: 0 finding(s) across 1 selected item(s). |
anyxem
force-pushed
the
feat/account_order_error_message
branch
from
October 12, 2026 04:46
a5e72bf to
47f8b12
Compare
erubboli
approved these changes
Oct 12, 2026
anyxem
force-pushed
the
feat/account_order_error_message
branch
from
October 12, 2026 10:08
47f8b12 to
d67492c
Compare
anyxem
force-pushed
the
feat/account_order_error_message
branch
from
October 12, 2026 10:09
d67492c to
65834a4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Format the order ID with lower-hex in
OrderOverbiderrors, so RPC andmempool responses show the complete 64-character identifier rather than
an abbreviated value.
Add regression coverage for the rendered error message.