Skip to content

turn on include_subdomains#16953

Open
ttipler wants to merge 6 commits into
mainfrom
OPS-1170
Open

turn on include_subdomains#16953
ttipler wants to merge 6 commits into
mainfrom
OPS-1170

Conversation

@ttipler

@ttipler ttipler commented Jun 1, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@ttipler ttipler requested review from a team as code owners June 1, 2026 15:29
@github-actions github-actions Bot added the environments-repository Used to exclude PRs from this repo in our Slack PR update label Jun 1, 2026
@ttipler ttipler temporarily deployed to youth-justice-app-framework-development June 1, 2026 15:32 — with GitHub Actions Inactive
@ttipler ttipler temporarily deployed to youth-justice-app-framework-test June 1, 2026 15:34 — with GitHub Actions Inactive
@github-actions

github-actions Bot commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

⚠️ Binary or Archive Files Detected

The following files match binary or archive extensions:

  • terraform/environments/youth-justice-app-framework/lambda_code/malware-threat-notifier.zip (Extension: .zip, Size: 0MB)

The Modernisation Platform Team urge you to consider storing these files outside of this git repository for the following reasons:

  • These file types are often large, which can bloat the repository and slow down cloning and fetching for all users.
  • Storing such files in git goes against best practices; they are better managed in object storage (e.g. S3 or artifact repositories).
  • Binary and archive files cannot be efficiently diffed or merged, making code review and collaboration difficult.

If you believe these files are necessary, please contact the Modernisation Platform Team for a review.

@ttipler ttipler temporarily deployed to youth-justice-app-framework-development June 2, 2026 12:50 — with GitHub Actions Inactive
@ttipler ttipler temporarily deployed to youth-justice-app-framework-test June 2, 2026 12:50 — with GitHub Actions Inactive
@ttipler ttipler temporarily deployed to youth-justice-app-framework-test June 8, 2026 08:59 — with GitHub Actions Inactive
@ttipler ttipler temporarily deployed to youth-justice-app-framework-development June 8, 2026 09:00 — with GitHub Actions Inactive
@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Checkov Scan Success

Show Output
*****************************

Checkov will check the following folders:
terraform/environments/youth-justice-app-framework
terraform/environments/youth-justice-app-framework/modules/aurora
terraform/environments/youth-justice-app-framework/modules/cloudfront

*****************************

Running Checkov in terraform/environments/youth-justice-app-framework
terraform scan results:

Passed checks: 1386, Failed checks: 2, Skipped checks: 235

Check: CKV_AWS_297: "Ensure EventBridge Scheduler Schedule uses Customer Managed Key (CMK)"
	FAILED for resource: module.aurora.aws_scheduler_schedule.rds_start
	File: /modules/aurora/event_scheduler.tf:36-54
	Calling File: /aurora.tf:13-126
	Guide: https://docs.prismacloud.io/en/enterprise-edition/policy-reference/aws-policies/aws-general-policies/bc-aws-297

		36 | resource "aws_scheduler_schedule" "rds_start" {
		37 |   count                        = var.create_sheduler ? 1 : 0
		38 |   name                         = "rds-start-weekdays"
		39 |   schedule_expression_timezone = "Europe/London"
		40 |   schedule_expression          = "cron(0 7 ? * MON-FRI *)"
		41 |
		42 |   flexible_time_window {
		43 |     mode = "OFF"
		44 |   }
		45 |
		46 |   target {
		47 |     arn      = "arn:aws:scheduler:::aws-sdk:rds:startDBCluster"
		48 |     role_arn = aws_iam_role.rds_scheduler[0].arn
		49 |
		50 |     input = jsonencode({
		51 |       DbClusterIdentifier = var.name
		52 |     })
		53 |   }
		54 | }

Check: CKV_AWS_297: "Ensure EventBridge Scheduler Schedule uses Customer Managed Key (CMK)"
	FAILED for resource: module.aurora.aws_scheduler_schedule.rds_stop
	File: /modules/aurora/event_scheduler.tf:57-75
	Calling File: /aurora.tf:13-126
	Guide: https://docs.prismacloud.io/en/enterprise-edition/policy-reference/aws-policies/aws-general-policies/bc-aws-297

		57 | resource "aws_scheduler_schedule" "rds_stop" {
		58 |   count                        = var.create_sheduler ? 1 : 0
		59 |   name                         = "rds-stop-weekdays"
		60 |   schedule_expression_timezone = "Europe/London"
		61 |   schedule_expression          = "cron(0 20 ? * MON-FRI *)"
		62 |
		63 |   flexible_time_window {
		64 |     mode = "OFF"
		65 |   }
		66 |
		67 |   target {
		68 |     arn      = "arn:aws:scheduler:::aws-sdk:rds:stopDBCluster"
		69 |     role_arn = aws_iam_role.rds_scheduler[0].arn
		70 |
		71 |     input = jsonencode({
		72 |       DbClusterIdentifier = var.name
		73 |     })
		74 |   }
		75 | }

terraform_plan scan results:

Passed checks: 0, Failed checks: 0, Skipped checks: 0, Parsing errors: 6

secrets scan results:

Passed checks: 0, Failed checks: 0, Skipped checks: 1


checkov_exitcode=1

*****************************

Running Checkov in terraform/environments/youth-justice-app-framework/modules/aurora
terraform scan results:

Passed checks: 47, Failed checks: 2, Skipped checks: 9

Check: CKV_AWS_297: "Ensure EventBridge Scheduler Schedule uses Customer Managed Key (CMK)"
	FAILED for resource: aws_scheduler_schedule.rds_start[0]
	File: /event_scheduler.tf:36-54
	Guide: https://docs.prismacloud.io/en/enterprise-edition/policy-reference/aws-policies/aws-general-policies/bc-aws-297

		36 | resource "aws_scheduler_schedule" "rds_start" {
		37 |   count                        = var.create_sheduler ? 1 : 0
		38 |   name                         = "rds-start-weekdays"
		39 |   schedule_expression_timezone = "Europe/London"
		40 |   schedule_expression          = "cron(0 7 ? * MON-FRI *)"
		41 |
		42 |   flexible_time_window {
		43 |     mode = "OFF"
		44 |   }
		45 |
		46 |   target {
		47 |     arn      = "arn:aws:scheduler:::aws-sdk:rds:startDBCluster"
		48 |     role_arn = aws_iam_role.rds_scheduler[0].arn
		49 |
		50 |     input = jsonencode({
		51 |       DbClusterIdentifier = var.name
		52 |     })
		53 |   }
		54 | }

Check: CKV_AWS_297: "Ensure EventBridge Scheduler Schedule uses Customer Managed Key (CMK)"
	FAILED for resource: aws_scheduler_schedule.rds_stop[0]
	File: /event_scheduler.tf:57-75
	Guide: https://docs.prismacloud.io/en/enterprise-edition/policy-reference/aws-policies/aws-general-policies/bc-aws-297

		57 | resource "aws_scheduler_schedule" "rds_stop" {
		58 |   count                        = var.create_sheduler ? 1 : 0
		59 |   name                         = "rds-stop-weekdays"
		60 |   schedule_expression_timezone = "Europe/London"
		61 |   schedule_expression          = "cron(0 20 ? * MON-FRI *)"
		62 |
		63 |   flexible_time_window {
		64 |     mode = "OFF"
		65 |   }
		66 |
		67 |   target {
		68 |     arn      = "arn:aws:scheduler:::aws-sdk:rds:stopDBCluster"
		69 |     role_arn = aws_iam_role.rds_scheduler[0].arn
		70 |
		71 |     input = jsonencode({
		72 |       DbClusterIdentifier = var.name
		73 |     })
		74 |   }
		75 | }


checkov_exitcode=2

*****************************

Running Checkov in terraform/environments/youth-justice-app-framework/modules/cloudfront
terraform scan results:

Passed checks: 32, Failed checks: 0, Skipped checks: 17


checkov_exitcode=2

TFLint Scan Success

Show Output
*****************************

Using default config
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.9.1)
tflint checking:
terraform/environments/youth-justice-app-framework
terraform/environments/youth-justice-app-framework/modules/aurora
terraform/environments/youth-justice-app-framework/modules/cloudfront

*****************************

Running tflint in terraform/environments/youth-justice-app-framework
tflint_exitcode=0

*****************************

Running tflint in terraform/environments/youth-justice-app-framework/modules/aurora
tflint_exitcode=0

*****************************

Running tflint in terraform/environments/youth-justice-app-framework/modules/cloudfront
tflint_exitcode=0

@ttipler ttipler deployed to youth-justice-app-framework-test June 8, 2026 11:22 — with GitHub Actions Active
@ttipler ttipler deployed to youth-justice-app-framework-development June 8, 2026 11:22 — with GitHub Actions Active
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

environments-repository Used to exclude PRs from this repo in our Slack PR update

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant