Skip to content

add tag backup false#16900

Open
BrianEllwood wants to merge 2 commits into
mainfrom
remove-eks-nodes-from-backup
Open

add tag backup false#16900
BrianEllwood wants to merge 2 commits into
mainfrom
remove-eks-nodes-from-backup

Conversation

@BrianEllwood
Copy link
Copy Markdown
Contributor

This pull request introduces updates to both Terraform and Helm configuration files to ensure that EKS nodes and Karpenter-managed node classes are tagged with backup: "false". This change standardizes the backup tagging policy across different node groups, making it explicit that these nodes should not be included in backup processes.

Tagging updates for EKS node groups and Karpenter node classes:

Terraform EKS node group updates:

  • Added launch_template_tags with backup = "false" to the general-purpose node group in eks-cluster.tf, ensuring these nodes are excluded from backup routines.
  • Added launch_template_tags with backup = "false" to the high-memory node group in eks-cluster.tf, applying the same backup exclusion policy.

Helm Karpenter node class updates:

  • Added tags: backup: "false" to the Bottlerocket general node class Helm template, so Karpenter-managed nodes are also excluded from backups.
  • Added tags: backup: "false" to the Bottlerocket GPU node class Helm template for consistent backup exclusion.

This work is been tracked in this ticket

@BrianEllwood BrianEllwood requested review from a team as code owners May 28, 2026 12:58
@github-actions github-actions Bot added the environments-repository Used to exclude PRs from this repo in our Slack PR update label May 28, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 2, 2026


Checkov Scan Success

Show Output
*****************************

Checkov will check the following folders:
terraform/environments/analytical-platform-compute/cluster

*****************************

Running Checkov in terraform/environments/analytical-platform-compute/cluster
terraform scan results:

Passed checks: 78, Failed checks: 0, Skipped checks: 70


checkov_exitcode=0

TFLint Scan Success

Show Output
*****************************

Using default config
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.9.1)
tflint checking:
terraform/environments/analytical-platform-compute/cluster

*****************************

Running tflint in terraform/environments/analytical-platform-compute/cluster
tflint_exitcode=0

@BrianEllwood BrianEllwood had a problem deploying to analytical-platform-compute-test-cluster June 2, 2026 08:05 — with GitHub Actions Error
@BrianEllwood BrianEllwood had a problem deploying to analytical-platform-compute-development-cluster June 2, 2026 08:05 — with GitHub Actions Error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

environments-repository Used to exclude PRs from this repo in our Slack PR update

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant