add tag backup false#16900
Open
BrianEllwood wants to merge 2 commits into
Open
Conversation
Contributor
|
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces updates to both Terraform and Helm configuration files to ensure that EKS nodes and Karpenter-managed node classes are tagged with
backup: "false". This change standardizes the backup tagging policy across different node groups, making it explicit that these nodes should not be included in backup processes.Tagging updates for EKS node groups and Karpenter node classes:
Terraform EKS node group updates:
launch_template_tagswithbackup = "false"to the general-purpose node group ineks-cluster.tf, ensuring these nodes are excluded from backup routines.launch_template_tagswithbackup = "false"to the high-memory node group ineks-cluster.tf, applying the same backup exclusion policy.Helm Karpenter node class updates:
tags: backup: "false"to the Bottlerocket general node class Helm template, so Karpenter-managed nodes are also excluded from backups.tags: backup: "false"to the Bottlerocket GPU node class Helm template for consistent backup exclusion.This work is been tracked in this ticket