Add unit/regression tests#17
Merged
Merged
Conversation
minisbett
added
feature
…`LegacyDifficultyCalculatorBeatmapDecoder`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds unit tests covering all of osu-native.
The unit test interacts with osu-native by calling the high-level
[OsuNativeFunction]methods, rather than using the FFI. This is deemed okay, as the concept of FFI should always reliably work, and the error-handling that differentiates the higher-level functions from the native ones is deterministic and tested as well.Coverage:
RulesetTestsBeatmapTestsModTestsModsCollectionTestsOsuDifficultyCalculatorTestsTaikoDifficultyCalculatorTestsCatchDifficultyCalculatorTestsManiaDifficultyCalculatorTestsOsuPerformanceCalculatorTestsTaikoPerformanceCalculatorTestsCatchPerformanceCalculatorTestsManiaPerformanceCalculatorTestsErrorHandlerTestsManagedObjectStoreTests(including handles)Additionally, the following is done:
.ideafolder is addedOsuNativeMarkeris removedosu.Native.OsuNativeis introduced, and the entry assembly setting is moved thereTestproject is removed