Skip to content

Add DumpMessages/AlterRole/UpdateUser interfaces#527

Merged
sre-ci-robot merged 1 commit into
milvus-io:masterfrom
yhmo:ma
Jun 25, 2026
Merged

Add DumpMessages/AlterRole/UpdateUser interfaces#527
sre-ci-robot merged 1 commit into
milvus-io:masterfrom
yhmo:ma

Conversation

@yhmo

@yhmo yhmo commented Jun 24, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

Signed-off-by: yhmo <yihua.mo@zilliz.com>
@sre-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yhmo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify

mergify Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@mergify mergify Bot added the dco-passed label Jun 24, 2026
Comment thread examples/src/v2/cdc.cpp
Comment thread src/impl/MilvusClientV2Impl.cpp
@codecov

codecov Bot commented Jun 24, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 91.87817% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.38%. Comparing base (a0592aa) to head (ff0be8d).
⚠️ Report is 117 commits behind head on master.

Files with missing lines Patch % Lines
src/impl/MilvusConnection.cpp 62.50% 12 Missing ⚠️
src/impl/MilvusClientV2Impl.cpp 94.64% 3 Missing ⚠️
src/impl/utils/TypeUtils.cpp 90.90% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #527       +/-   ##
===========================================
+ Coverage   53.47%   78.38%   +24.90%     
===========================================
  Files          52      355      +303     
  Lines        4432    14928    +10496     
  Branches        0     1428     +1428     
===========================================
+ Hits         2370    11701     +9331     
- Misses       2062     3109     +1047     
- Partials        0      118      +118     
Files with missing lines Coverage Δ
src/impl/MilvusClientV2Impl.h 100.00% <ø> (ø)
src/impl/MilvusConnection.h 94.11% <ø> (-2.55%) ⬇️
src/impl/request/cdc/DumpMessagesRequest.cpp 100.00% <100.00%> (ø)
src/impl/request/rbac/AlterRoleRequest.cpp 100.00% <100.00%> (ø)
src/impl/request/rbac/UpdateUserRequest.cpp 100.00% <100.00%> (ø)
src/impl/response/cdc/DumpMessagesTypes.cpp 100.00% <100.00%> (ø)
src/impl/response/cdc/GetReplicateInfoResponse.cpp 100.00% <100.00%> (ø)
src/impl/types/RoleDesc.cpp 100.00% <100.00%> (+100.00%) ⬆️
src/impl/types/UserDesc.cpp 100.00% <100.00%> (ø)
src/include/milvus/MilvusClientV2.h 100.00% <ø> (ø)
... and 5 more

... and 357 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sre-ci-robot sre-ci-robot merged commit 6fe6455 into milvus-io:master Jun 25, 2026
15 of 18 checks passed
@mergify mergify Bot removed the ci-passed label Jun 25, 2026
@yhmo yhmo deleted the ma branch June 25, 2026 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants