Skip to content

Add DumpMessages/AlterRole/UpdateUser interfaces#526

Merged
sre-ci-robot merged 1 commit into
milvus-io:2.6from
yhmo:26
Jun 25, 2026
Merged

Add DumpMessages/AlterRole/UpdateUser interfaces#526
sre-ci-robot merged 1 commit into
milvus-io:2.6from
yhmo:26

Conversation

@yhmo

@yhmo yhmo commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@sre-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yhmo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify

mergify Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@mergify mergify Bot added the dco-passed label Jun 23, 2026
@yhmo yhmo force-pushed the 26 branch 2 times, most recently from 1c4b407 to 42f6de6 Compare June 23, 2026 11:27
@codecov

codecov Bot commented Jun 23, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 91.87817% with 16 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (2.6@673b0ea). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/impl/MilvusConnection.cpp 62.50% 12 Missing ⚠️
src/impl/MilvusClientV2Impl.cpp 94.64% 3 Missing ⚠️
src/impl/utils/TypeUtils.cpp 90.90% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff           @@
##             2.6     #526   +/-   ##
======================================
  Coverage       ?   77.77%           
======================================
  Files          ?      312           
  Lines          ?    14076           
  Branches       ?     1363           
======================================
  Hits           ?    10947           
  Misses         ?     3013           
  Partials       ?      116           
Files with missing lines Coverage Δ
src/impl/MilvusClientV2Impl.h 100.00% <ø> (ø)
src/impl/MilvusConnection.h 94.11% <ø> (ø)
src/impl/request/cdc/DumpMessagesRequest.cpp 100.00% <100.00%> (ø)
src/impl/request/rbac/AlterRoleRequest.cpp 100.00% <100.00%> (ø)
src/impl/request/rbac/UpdateUserRequest.cpp 100.00% <100.00%> (ø)
src/impl/response/cdc/DumpMessagesTypes.cpp 100.00% <100.00%> (ø)
src/impl/response/cdc/GetReplicateInfoResponse.cpp 100.00% <100.00%> (ø)
src/impl/types/RoleDesc.cpp 100.00% <100.00%> (ø)
src/impl/types/UserDesc.cpp 100.00% <100.00%> (ø)
src/include/milvus/MilvusClientV2.h 100.00% <ø> (ø)
... and 5 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread src/impl/MilvusClientV2Impl.cpp Outdated
Comment thread src/impl/MilvusClientV2Impl.cpp Outdated
Comment thread src/impl/MilvusClientV2Impl.cpp
Comment thread src/impl/MilvusClientV2Impl.cpp Outdated
Comment thread src/impl/MilvusClientV2Impl.cpp Outdated
Comment thread examples/src/v2/cdc.cpp
Comment thread examples/src/v2/cdc.cpp Outdated
Signed-off-by: yhmo <yihua.mo@zilliz.com>
@mergify mergify Bot added the ci-passed label Jun 24, 2026
@yhmo yhmo added the lgtm label Jun 25, 2026
@sre-ci-robot sre-ci-robot merged commit fca38f3 into milvus-io:2.6 Jun 25, 2026
12 checks passed
@yhmo yhmo deleted the 26 branch June 25, 2026 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants