fix: pre-commit hook now blocks commits when diagnostics are found

[skoshx]

Root Cause

The generated pre-commit hook captured react-doctor output to a temp file but never exited with non-zero status when diagnostics were found. This allowed commits to proceed even when blocking diagnostics were present, completely defeating the purpose of the hook.

The bug existed in two places:

1. buildReactDoctorHookBlock() in install-git-hook-file.ts
2. NON_BLOCKING_REACT_DOCTOR_COMMAND in git-hook-shared.ts

Both implementations had the same flaw:

• Captured output to a temp file
• Deleted the file in both success and failure branches
• Never called exit 1 in the failure branch
• Printed a generic message but allowed the commit to proceed

Fix

The hook now:

1. Displays the full react-doctor output to stderr (so users see which rules failed)
2. Exits with status 1 when diagnostics are found (blocking the commit)
3. Cleans up the temp file after displaying output

Testing

• Updated existing integration test that was expecting non-blocking behavior
• Test now verifies the commit is blocked (exit code 1) when react-doctor fails
• Test verifies react-doctor output is displayed to the user
• All existing tests pass

Closes #969

  

[pkg-pr-new]

Open in StackBlitz

npm i https://pkg.pr.new/eslint-plugin-react-doctor@970

npm i https://pkg.pr.new/oxlint-plugin-react-doctor@970

npm i https://pkg.pr.new/react-doctor@970

commit: 302cb0b