Skip to content

Simplify deslop stale package detection#919

Draft
cursor[bot] wants to merge 4 commits into
mainfrom
cursor/system-elegance-audit-d1a2
Draft

Simplify deslop stale package detection#919
cursor[bot] wants to merge 4 commits into
mainfrom
cursor/system-elegance-audit-d1a2

Conversation

@cursor

@cursor cursor Bot commented Jun 21, 2026

Copy link
Copy Markdown

Summary

  • simplify stale dependency package-json discovery and root manifest reuse
  • remove redundant override/bin helper logic and avoid mutating rescue-scan inputs
  • strengthen deslop fixture tests for type-only deps, orphan subtree coverage, and duplicate-block clustering

Verification

  • pnpm exec turbo run test --filter=deslop-js --filter=deslop-cli
  • pnpm exec turbo run typecheck --filter=deslop-js --filter=deslop-cli
  • npx deslop-cli@latest --json . summarized existing repo-wide dead-code findings

Notes

  • pnpm exec vp fmt --check ... and pnpm exec vp lint ... were blocked by the runner's Node 22.14.0; the config loader requires ^20.19.0 || >=22.18.0 for the TypeScript vite.config.ts path.
  • truffler could not run because this runner has no bun binary and @rayhanadev/truffler delegates to Bun.
Open in Web View Automation 

cursoragent and others added 3 commits June 21, 2026 16:09
Co-authored-by: Aiden Bai <aidenybai@users.noreply.github.com>
Co-authored-by: Aiden Bai <aidenybai@users.noreply.github.com>
Co-authored-by: Aiden Bai <aidenybai@users.noreply.github.com>

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/rde parity

View PR

Open in Web View Automation 

Sent by Cursor Automation: React Doctor Cleanup

@pkg-pr-new

pkg-pr-new Bot commented Jun 21, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/eslint-plugin-react-doctor@919
npm i https://pkg.pr.new/oxlint-plugin-react-doctor@919
npm i https://pkg.pr.new/react-doctor@919

commit: 3c04392

Co-authored-by: Aiden Bai <aidenybai@users.noreply.github.com>

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automation summary:

  • Simplified deslop-js stale-package detection internals: root package metadata is parsed once, package-json path discovery stays deduped, search roots are shared, the redundant override branch is gone, and the source rescue scan no longer mutates caller-owned state.
  • Tightened targeted deslop tests for type-only dependency usage, orphan subtree coverage, duplicate-block clustering, and reduced repeated simple-app scans.
  • Posted /rde parity as requested. No RDE response or Bugbot comments appeared while polling.

Verification:

  • pnpm exec turbo run test --filter=deslop-js --filter=deslop-cli
  • pnpm exec turbo run typecheck --filter=deslop-js --filter=deslop-cli
  • npx -p node@22.18.0 -c "pnpm exec vp fmt --check packages/deslop-js/src/report/packages.ts packages/deslop-js/tests/analyze.test.ts"
  • PR checks are green, including Code Quality, CodeQL, React Doctor, and the OS/Node CI matrix.

Notes:

  • truffler could not run on this runner because @rayhanadev/truffler delegates to bun, and bun is not installed.
  • Direct local vp fmt / vp lint under the runner's Node 22.14.0 could not load the TypeScript vite.config.ts; running the formatter under Node 22.18.0 matched CI and passed.

View PR

Open in Web View Automation 

Sent by Cursor Automation: React Doctor Cleanup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant