Simplify deslop stale package detection#919
Draft
cursor[bot] wants to merge 4 commits into
Draft
Conversation
Co-authored-by: Aiden Bai <aidenybai@users.noreply.github.com>
Co-authored-by: Aiden Bai <aidenybai@users.noreply.github.com>
Co-authored-by: Aiden Bai <aidenybai@users.noreply.github.com>
commit: |
Co-authored-by: Aiden Bai <aidenybai@users.noreply.github.com>
Author
There was a problem hiding this comment.
Automation summary:
- Simplified
deslop-jsstale-package detection internals: root package metadata is parsed once, package-json path discovery stays deduped, search roots are shared, the redundant override branch is gone, and the source rescue scan no longer mutates caller-owned state. - Tightened targeted deslop tests for type-only dependency usage, orphan subtree coverage, duplicate-block clustering, and reduced repeated
simple-appscans. - Posted
/rde parityas requested. No RDE response or Bugbot comments appeared while polling.
Verification:
pnpm exec turbo run test --filter=deslop-js --filter=deslop-clipnpm exec turbo run typecheck --filter=deslop-js --filter=deslop-clinpx -p node@22.18.0 -c "pnpm exec vp fmt --check packages/deslop-js/src/report/packages.ts packages/deslop-js/tests/analyze.test.ts"- PR checks are green, including Code Quality, CodeQL, React Doctor, and the OS/Node CI matrix.
Notes:
trufflercould not run on this runner because@rayhanadev/trufflerdelegates tobun, andbunis not installed.- Direct local
vp fmt/vp lintunder the runner's Node22.14.0could not load the TypeScriptvite.config.ts; running the formatter under Node22.18.0matched CI and passed.
Sent by Cursor Automation: React Doctor Cleanup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
Verification
pnpm exec turbo run test --filter=deslop-js --filter=deslop-clipnpm exec turbo run typecheck --filter=deslop-js --filter=deslop-clinpx deslop-cli@latest --json .summarized existing repo-wide dead-code findingsNotes
pnpm exec vp fmt --check ...andpnpm exec vp lint ...were blocked by the runner's Node22.14.0; the config loader requires^20.19.0 || >=22.18.0for the TypeScriptvite.config.tspath.trufflercould not run because this runner has nobunbinary and@rayhanadev/trufflerdelegates to Bun.