Refactor dependency discovery cleanup#877
Draft
cursor[bot] wants to merge 3 commits into
Draft
Conversation
Co-authored-by: Aiden Bai <aidenybai@users.noreply.github.com>
Co-authored-by: Aiden Bai <aidenybai@users.noreply.github.com>
Co-authored-by: Aiden Bai <aidenybai@users.noreply.github.com>
commit: |
Contributor
|
No React Doctor issues found. 🎉 Reviewed by React Doctor for commit |
Author
There was a problem hiding this comment.
Cleanup pass completed.
Summary:
- Hardened dependency/version readers against malformed non-string package specs.
- Reused one workspace dependency spec finder for Expo, Next.js, and FlashList detection.
- Removed small oxlint-plugin cleanup targets from the deslop/reviewer pass: duplicate import, dead constant export, unnecessary Expo managed set export, and a redundant semantic helper parameter.
Verification:
- Local:
pnpm lint,pnpm format:check,pnpm typecheck,pnpm --filter @react-doctor/core test,pnpm --filter oxlint-plugin-react-doctor testunder Node 22.18.0. - PR: all visible CI, Code Quality, CodeQL, React Doctor, and Publish Any Commit checks are green.
Notes:
- Posted
/rde parityvia the available PR review channel. No separate RDE result or Bugbot feedback appeared during the polling window. trufflercould not run in this environment because its binary requiresbun; I used targeted repo searches plusdeslop-clioutput instead.
Sent by Cursor Automation: React Doctor Cleanup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
Verification
pnpm lint(Node 22.18.0)pnpm format:check(Node 22.18.0)pnpm typecheck(Node 22.18.0)pnpm --filter @react-doctor/core testpnpm --filter oxlint-plugin-react-doctor test