Refactor CLI prompt decision cleanup#854
Draft
cursor[bot] wants to merge 3 commits into
Draft
Conversation
Co-authored-by: Aiden Bai <aidenybai@users.noreply.github.com>
commit: |
Contributor
|
No React Doctor issues found. 🎉 Reviewed by React Doctor for commit |
Co-authored-by: Aiden Bai <aidenybai@users.noreply.github.com>
Co-authored-by: Aiden Bai <aidenybai@users.noreply.github.com>
Author
There was a problem hiding this comment.
Completed the cleanup pass.
Summary:
- Removed unused prompt-decision type aliases and a dead git-hook constant re-export found by
deslop-cli. - Trimmed stale/low-value comments and tightened the shared project decision store key type.
- Removed repeated
ci-suppressedhandoff telemetry noise and added phase labels to the remaining handoff metric emissions. - Normalized
install.workflowmetric attributes and counted successful post-scan workflow upgrades. - Replaced avoidable type escapes/non-null assertions in the install/handoff paths and clarified the best-effort handoff payload write.
Verification:
- Focused touched tests: passed (
53tests). pnpm typecheck: passed.pnpm test: passed locally (1813tests,17skipped).pnpm smoke:json-report: passed.pnpm format:checkunder CI Node22.18.0: passed.- PR CI on latest head
3d43b72: all checks green, including lint/typecheck/test matrix/React Doctor/CodeQL.
Notes:
- Posted
/rde parityfor the PR head after each pushed update. - No Bugbot comments or separate RDE regression feedback appeared during the watch window.
- Skipped larger refactors called out by reviewers (shared prompt orchestrator, Conf-store migration, broader repo-wide deslop findings) because they exceed the scoped cleanup and need separate product/compatibility decisions.
Sent by Cursor Automation: React Doctor Cleanup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
Verification
pnpm --filter @react-doctor/core build && pnpm --filter react-doctor buildpnpm test tests/ci-prompt-decision.test.ts tests/install-react-doctor.test.ts tests/action-upgrade.test.ts tests/handoff/build-handoff-payload.test.ts(frompackages/react-doctor)pnpm typecheckpnpm testpnpm smoke:json-reportNotes
pnpm lintandpnpm format:checkare blocked in this environment by TS config loading under Node.jsv22.14.0; the tooling requests a newer compatible Node runtime.