Skip to content

Refactor CLI prompt decision cleanup#854

Draft
cursor[bot] wants to merge 3 commits into
mainfrom
cursor/codebase-architecture-elegance-c92e
Draft

Refactor CLI prompt decision cleanup#854
cursor[bot] wants to merge 3 commits into
mainfrom
cursor/codebase-architecture-elegance-c92e

Conversation

@cursor

@cursor cursor Bot commented Jun 17, 2026

Copy link
Copy Markdown

Summary

  • Removes unused prompt-decision aliases and a dead git-hook constant re-export.
  • Trims stale/low-value comments and tightens decision-store key typing.
  • Removes noisy repeated CI-suppression telemetry and normalizes workflow metric attributes.
  • Cleans small type escape/non-null assertion cases in the handoff/install flow.

Verification

  • pnpm --filter @react-doctor/core build && pnpm --filter react-doctor build
  • pnpm test tests/ci-prompt-decision.test.ts tests/install-react-doctor.test.ts tests/action-upgrade.test.ts tests/handoff/build-handoff-payload.test.ts (from packages/react-doctor)
  • pnpm typecheck
  • pnpm test
  • pnpm smoke:json-report

Notes

  • pnpm lint and pnpm format:check are blocked in this environment by TS config loading under Node.js v22.14.0; the tooling requests a newer compatible Node runtime.
Open in Web View Automation 

Co-authored-by: Aiden Bai <aidenybai@users.noreply.github.com>

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/rde parity

View PR

Open in Web View Automation 

Sent by Cursor Automation: React Doctor Cleanup

@pkg-pr-new

pkg-pr-new Bot commented Jun 17, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/eslint-plugin-react-doctor@854
npm i https://pkg.pr.new/oxlint-plugin-react-doctor@854
npm i https://pkg.pr.new/react-doctor@854

commit: 3d43b72

@github-actions

github-actions Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

No React Doctor issues found. 🎉

Reviewed by React Doctor for commit 3d43b72.

Co-authored-by: Aiden Bai <aidenybai@users.noreply.github.com>

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/rde parity

View PR

Open in Web View Automation 

Sent by Cursor Automation: React Doctor Cleanup

Co-authored-by: Aiden Bai <aidenybai@users.noreply.github.com>

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/rde parity

View PR

Open in Web View Automation 

Sent by Cursor Automation: React Doctor Cleanup

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Completed the cleanup pass.

Summary:

  • Removed unused prompt-decision type aliases and a dead git-hook constant re-export found by deslop-cli.
  • Trimmed stale/low-value comments and tightened the shared project decision store key type.
  • Removed repeated ci-suppressed handoff telemetry noise and added phase labels to the remaining handoff metric emissions.
  • Normalized install.workflow metric attributes and counted successful post-scan workflow upgrades.
  • Replaced avoidable type escapes/non-null assertions in the install/handoff paths and clarified the best-effort handoff payload write.

Verification:

  • Focused touched tests: passed (53 tests).
  • pnpm typecheck: passed.
  • pnpm test: passed locally (1813 tests, 17 skipped).
  • pnpm smoke:json-report: passed.
  • pnpm format:check under CI Node 22.18.0: passed.
  • PR CI on latest head 3d43b72: all checks green, including lint/typecheck/test matrix/React Doctor/CodeQL.

Notes:

  • Posted /rde parity for the PR head after each pushed update.
  • No Bugbot comments or separate RDE regression feedback appeared during the watch window.
  • Skipped larger refactors called out by reviewers (shared prompt orchestrator, Conf-store migration, broader repo-wide deslop findings) because they exceed the scoped cleanup and need separate product/compatibility decisions.

View PR

Open in Web View Automation 

Sent by Cursor Automation: React Doctor Cleanup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant