[Fix] Element.IndexPath is null after search was activated.#168
Open
alexshikov wants to merge 1 commit into
Open
[Fix] Element.IndexPath is null after search was activated.#168alexshikov wants to merge 1 commit into
alexshikov wants to merge 1 commit into
Conversation
Sample added: DemoColoredList.
Owner
|
I am not sure that I understand this patch, can you tell me how to reproduce the bug, so I can evaluate the patch? The sample is also wrong, when you subclass an Element, you must provide your own unique Key, otherwise the cells can be mixed up with other cells (likely you wont notice in this sample, but if you mix other stringelements, you would). |
Author
|
Steps to reproduce:
Actual result: IndexPath is null The provided sample is the test for the bug:
Sorry for incorrect using of unique Key and trash changes in Sample.csproj. Either I can fix pull-request or you can just close it and make fix in a better way : ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed an issue when Element.IndexPath is null after search was activated.
DemoColoredList added to test the issue:
As an option: move parent reassignment logic from DialogViewController to Section.