Make finding navigation controller in DVC more flexible#123
Conversation
This makes DVC work correctly in scenarios when it is nested deep in the hierarchy below a top-level navigation controller.
{Activate,Deactivate}Controller made virtual to allow for easier customization.
|
This patch changes the behavior for ActivateController, before it did: var parent = ParentViewController; Now nav is instead this.NavigationController, which might not be the parent. |
|
Will this version work better? |
|
Miguel, one part of grendello's changes allows for DVC to be embedded as a child view (for example in a split screen scenario). I am attaching the specific diff for that section below. If only these changes will get submitted as a pull, will you merge them in or do you see a problem with this setup? Thanks! |
|
@migueldeicaza RE:
I beleive that is the point of the pull request - to look higher than the immediate parent for a nav controller used to navigate. |
This makes DVC work correctly in scenarios when it is nested deep in the hierarchy below a top-level navigation controller.
{Activate,Deactivate}Controller made virtual to allow for easier customization.