-
Notifications
You must be signed in to change notification settings - Fork 0
Currency improvements #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
cf5ae9f
fix: attribute manual odometer readings to the last known activity date.
mightea 92717d5
feat: Implement dynamic currency selection in motorcycle and maintena…
mightea d30912b
feat: Introduce document privacy and normalized cost tracking, rebase…
mightea 772cd60
feat: Add script to add `tool_size` column to `torque_specs` table an…
mightea bdc8c4c
refactor: Remove unused imports, adjust import paths, and add normali…
mightea 2edaf5b
Update scripts/manual-fix.ts
mightea 9f64553
refactor: Remove default currency constants and fallback logic from a…
mightea 7cf8f5c
Merge remote-tracking branch 'refs/remotes/origin/currency-improvemen…
mightea 0dd5861
fix: use explicit null checks in backfill script to handle zero values
Copilot c97245c
fix: Fall back to cost when normalizedCost is null in maintenance totals
Copilot eca85a9
feat: Include currencies in motorcycle detail loader data and update …
mightea f81cd04
Refactor: Exclude 'general' and 'repair' types from the generic brand…
mightea File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| ALTER TABLE `motorcycles` ADD `normalized_purchase_price` real; | ||
| --> statement-breakpoint | ||
| ALTER TABLE `maintenance_records` ADD `normalized_cost` real; | ||
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
1 change: 0 additions & 1 deletion
1
app/db/migrations/0003_add_location_id_to_maintenance_records.sql
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This migration only contains
ALTER TABLEstatements, and the migrations folder no longer contains an initial schema/table-creation migration. Running migrations on a fresh database will fail becausemotorcycles/maintenance_recordswon’t exist yet. Reintroduce a baseline migration that creates the tables (or otherwise ensure schema creation happens before these ALTERs).