security: squash audit issues around toolkit#1703
Conversation
Signed-off-by: Giles Cope <gilescope@gmail.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b51c47492a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "node_modules/@midnight-ntwrk/compact-js": { | ||
| "version": "2.4.3", | ||
| "resolved": "https://registry.npmjs.org/@midnight-ntwrk/compact-js/-/compact-js-2.4.3.tgz", | ||
| "resolved": "https://npm.pkg.github.com/download/@midnight-ntwrk/compact-js/2.4.3/73d3f05cbd25f9e46616cf4b0a88c3e1384ce3f8", |
There was a problem hiding this comment.
Keep toolkit packages on an unauthenticated registry
In clean toolkit builds, +toolkit-js-prep runs npm ci before the only GITHUB_TOKEN-backed command (npm run compact), and the repo has no .npmrc that authenticates npm to GitHub Packages. The new npm.pkg.github.com/download/... tarball URLs require GitHub Packages npm authentication even for public packages, so a cache-miss CI or local Earthly build will fail while installing these @midnight-ntwrk/* packages; keep these lockfile entries on registry.npmjs.org or configure npm auth before npm ci.
Useful? React with 👍 / 👎.
Overview
Fixed audit issues around toolkit js dependencies.
🗹 TODO before merging
📌 Submission Checklist
git commit -s) for the DCO🧪 Testing Evidence
Please describe any additional testing aside from CI:
🔱 Fork Strategy
Links