Skip to content

security: squash audit issues around toolkit#1703

Open
gilescope wants to merge 2 commits into
release/node-1.0.1from
giles-audit-node-1.0.1
Open

security: squash audit issues around toolkit#1703
gilescope wants to merge 2 commits into
release/node-1.0.1from
giles-audit-node-1.0.1

Conversation

@gilescope

Copy link
Copy Markdown
Contributor

Overview

Fixed audit issues around toolkit js dependencies.

🗹 TODO before merging

  • Ready

📌 Submission Checklist

  • All commits are signed off (git commit -s) for the DCO
  • Changes are backward-compatible (or flagged if breaking)
  • Pull request description explains why the change is needed
  • Self-reviewed the diff
  • I have included a change file, or skipped for this reason:
  • If the changes introduce a new feature, I have bumped the node minor version
  • Update documentation (if relevant)
  • Updated AGENTS.md if build commands, architecture, or workflows changed
  • No new todos introduced

🧪 Testing Evidence

Please describe any additional testing aside from CI:

  • Additional tests are provided (if possible)

🔱 Fork Strategy

  • Node Runtime Update
  • Node Client Update
  • Other:
  • N/A

Links

Signed-off-by: Giles Cope <gilescope@gmail.com>
@gilescope gilescope requested a review from a team as a code owner June 16, 2026 14:58

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b51c47492a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

"node_modules/@midnight-ntwrk/compact-js": {
"version": "2.4.3",
"resolved": "https://registry.npmjs.org/@midnight-ntwrk/compact-js/-/compact-js-2.4.3.tgz",
"resolved": "https://npm.pkg.github.com/download/@midnight-ntwrk/compact-js/2.4.3/73d3f05cbd25f9e46616cf4b0a88c3e1384ce3f8",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Keep toolkit packages on an unauthenticated registry

In clean toolkit builds, +toolkit-js-prep runs npm ci before the only GITHUB_TOKEN-backed command (npm run compact), and the repo has no .npmrc that authenticates npm to GitHub Packages. The new npm.pkg.github.com/download/... tarball URLs require GitHub Packages npm authentication even for public packages, so a cache-miss CI or local Earthly build will fail while installing these @midnight-ntwrk/* packages; keep these lockfile entries on registry.npmjs.org or configure npm auth before npm ci.

Useful? React with 👍 / 👎.

@gilescope gilescope enabled auto-merge June 16, 2026 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants