feat: replaced aura fork with sp-partner-chains-consensus#1700
feat: replaced aura fork with sp-partner-chains-consensus#1700Klapeyron wants to merge 1 commit into
Conversation
f498537 to
ffb74d8
Compare
Signed-off-by: Tomasz Bartos <tomasz.bartos@shielded.io>
ffb74d8 to
34e2a95
Compare
| authors.workspace = true | ||
| homepage.workspace = true | ||
| edition.workspace = true | ||
| license = "Apache-2.0" |
There was a problem hiding this comment.
Can't be Apache, because it depends on "sc-consensus"
There was a problem hiding this comment.
I am not sure that is correct. We are not making any modifications to the GPL3 code here, also existing primitives we migrated from PC are Apache licensed and GPL3 with Classpath exception exists precisely to let you link/combine that code with software under other licenses — including Apache — without the combined work becoming GPL, so an Apache crate depending on sc-consensus is exactly the intended use
There was a problem hiding this comment.
Classpath exception gives you ability to use GPL3 for building binary without having to GPL3 the code that builds this binary.
This is clearly library crate, it has to be tainted with GPL3. Exception doesn't work here.
Overview
🗹 TODO before merging
📌 Submission Checklist
git commit -s) for the DCO🧪 Testing Evidence
Please describe any additional testing aside from CI:
🔱 Fork Strategy
Links