-
Notifications
You must be signed in to change notification settings - Fork 35
ci: disable earthly TLS in bot workflows (settings-hash parity with CI) #1693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
c0f125a
f96d740
1d61c23
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -97,6 +97,16 @@ jobs: | |
| username: MidnightCI | ||
| password: ${{ secrets.MIDNIGHTCI_PACKAGES_READ }} | ||
|
|
||
| # Self-hosted-runner-specific: earthly's managed buildkitd defaults to TLS | ||
| # but no certs are provisioned on the runner. Beyond fixing this job's own | ||
| # TLS failure, this keeps the buildkit settings hash byte-identical with | ||
| # every other self-hosted earthly caller (see continuous-integration.yml) — | ||
| # a mismatched hash makes earthly force-recreate the shared buildkitd, | ||
| # cancelling every in-flight build on the box. | ||
| - name: Disable earthly TLS (self-hosted runner has no certs) | ||
| run: | | ||
| echo " tls_enabled: false" >> .earthly/config.yml | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
On self-hosted runners, the other Earthly workflows source Useful? React with 👍 / 👎. |
||
|
|
||
| - name: Run rebuild-metadata | ||
| env: | ||
| EARTHLY_CONFIG: .earthly/config.yml | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On self-hosted runners, the other Earthly workflows source
.envrcbefore invoking Earthly (for example.github/workflows/continuous-integration.yml:648), and.envrc:29-30switches them to.earthly/config.selfhosted.yml, which includes bothtls_enabled: falseandbuildkit_additional_args: ["-m", "180Gb"](.earthly/config.selfhosted.yml:15-20). This bot still runs withEARTHLY_CONFIG: .earthly/config.yml, so appending only TLS leaves its BuildKit settings hash different from CI and the chainspec bot can still force-recreate the sharedearthly-buildkitdon each run. Use the same self-hosted config (or source.envrc) for the bot invocation instead of patching the default config.Useful? React with 👍 / 👎.