ci: return of the chef#1645
Conversation
Signed-off-by: Giles Cope <gilescope@gmail.com>
gilescope
force-pushed
the
giles-chef-comeback
branch
from
6db81e5 to
03a1099
Compare
Signed-off-by: Giles Cope <gilescope@gmail.com>
… temp enable cache push - Remove the separate +test-pallet-fixtures target/job; run the 3 fixture tests inside +test (same release build, no second cold compile). - DEPS_CACHE_REPO -> ghcr.io/midnightntwrk (migration target / pushable org). - ALLOW_CACHE_PUSH=true temporarily to populate the cache (TODO before-merge). Signed-off-by: Giles Cope <gilescope@gmail.com>
# Conflicts: # Earthfile
Signed-off-by: Giles Cope <gilescope@gmail.com>
Signed-off-by: Giles Cope <gilescope@gmail.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 48787a5e51
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Signed-off-by: Giles Cope <gilescope@gmail.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2c707c02e3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ARG NATIVEARCH | ||
| ARG RUST_VERSION=$(grep '^channel' /rust-toolchain.toml | sed 's/.*"\(.*\)".*/\1/') | ||
| ARG RECIPE_HASH=$(sha256sum /recipe.json | cut -c1-16) | ||
| ARG DEPS_TAG=${RUST_VERSION}-${NATIVEARCH}-build-${RECIPE_HASH} |
There was a problem hiding this comment.
The seed workflow only invokes +seed-deps, which computes and pushes the ...-build-... tag here, but +check probes a separate ...-check-... tag in check-rust-prepare and the check workflows run earthly +check without --push or ALLOW_CACHE_PUSH=true. As a result, after Cargo/rust-toolchain changes the clippy/check dependency cache can never be populated by the new workflow, so every check CI run will keep cooking the full check-flavor dependency graph locally instead of reusing the intended registry cache.
Useful? React with 👍 / 👎.
3 participants
Overview
Re-enables cargo-chef dep caching and adds line-number backtraces to release binaries.
Chef cache: deps images are content-addressed by
<rust>-<arch>-<flavor>-<recipe_hash>. Cache miss = cook locally (same cost as today); hit = pull.ALLOW_CACHE_PUSHdefaultsfalseso PRs can't poison the cache. Rungh workflow run seed-deps-cache.ymlafter merge to populate the registry.Backtraces:
line-tables-onlyfor first-party crates,debug=0for deps. Binary size ~331 MB (vs ~181 no-debug).CI fixes:
--strict/--cifrom jobs whose graph reaches+cache-probe(LOCALLYbreaks strict mode)DEPS_CACHE_REPO:midnight-ntwrk→midnightntwrk(correct org post-migration)+test-pallet-fixturesinto+test(was paying for a second cold--releasecompile)BUILD +cook-buildbeforeFROM +cook-buildsoSAVE IMAGE --pushfires (earthly skips pushes on pure-FROM targets)🗹 TODO before merging
ALLOW_CACHE_PUSHback tofalsegh workflow run seed-deps-cache.ymlafter merge📌 Submission Checklist
git commit -s) for the DCOchanges/node/changed/line-table-backtraces-and-dependency-cache.md🧪 Testing Evidence
CI green. Cache-miss timings (no registry image yet — speedup comes after seeder runs):
🔱 Fork Strategy
Links
Issue: N/A