Augment interface of unproven-call-tx.ts to allow cross-contract calls#863
Open
christianschmitz wants to merge 3 commits into
Open
Augment interface of unproven-call-tx.ts to allow cross-contract calls#863christianschmitz wants to merge 3 commits into
christianschmitz wants to merge 3 commits into
Conversation
…ovenCallTxFromInitialStates that also return ZswapLocalState
|
|
christianschmitz
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've requested some changes to make it easier to do cross-contract calls
communicationCommitmentRandis threaded all the way from call options intoContractCallPrototype. Default behavior is unchanged when the field is omitted, because the ledger still generates fresh randomness in that case. The difference is that callers can now provide the exact communication commitment randomness when they need the call transaction to line up with a separately-constructed opening of transientCommit of calling circuits.Create a variant of
createUnprovenCallTxFromInitialStates()calledcreateUnprovenCallTxFromInitialStatesWithZswapLocalState(), which also returns the zswapLocalState. This is more convenient than rebuilding the zswapLocalState externally. We need the zswapLocalState to figure out which outputs are created by the tx, so we can merge them as transient coins in cross-contract calls.