Unhide callerIdNumber on voiceAuthenticationMethodConfiguration (beta)#9937
Unhide callerIdNumber on voiceAuthenticationMethodConfiguration (beta)#9937trsadara wants to merge 4 commits into
Conversation
… (beta) Add the callerIdNumber property to the voiceAuthenticationMethodConfiguration resource type documentation for the beta API reference. This property was previously hidden and is being exposed as part of the voice call settings feature rollout. Files updated: - Resource type: added callerIdNumber to Properties table and JSON representation - GET API: added callerIdNumber to response example - UPDATE API: added callerIdNumber to request body properties table Related AGS schema change: https://dev.azure.com/msazure/One/_git/AD-AggregatorService-Workloads/pullrequest/15464627 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Learn Build status updates of commit 49add41: ✅ Validation status: passed
For more details, please refer to the build report. |
Include format guidance (E.164, e.g. +15551234567) in the callerIdNumber property descriptions and JSON examples to avoid ambiguity in public docs. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Remove E.164 format claim since there is no format validation at the API layer. Pending confirmation from PM/telephony team on the accepted format before adding specific format guidance. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Learn Build status updates of commit 9aeded9: ✅ Validation status: passed
For more details, please refer to the build report. |
|
Learn Build status updates of commit 14165a5: ✅ Validation status: passed
For more details, please refer to the build report. |
Specify that callerIdNumber only supports US phone numbers in 10-digit or 11-digit (with country code 1) format. Non-numeric characters are ignored. Invalid values fall back to the system default caller ID. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Learn Build status updates of commit 32ab135: ✅ Validation status: passed
For more details, please refer to the build report. |
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds documentation for a new callerIdNumber setting on voiceAuthenticationMethodConfiguration, including how to set it via PATCH and how it appears in JSON examples.
Changes:
- Documented the new
callerIdNumberproperty on thevoiceAuthenticationMethodConfigurationresource. - Added
callerIdNumberto the Update (PATCH) API property table. - Updated the Get API response example to include
callerIdNumber.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| api-reference/beta/resources/voiceauthenticationmethodconfiguration.md | Adds callerIdNumber to the resource properties and JSON representation. |
| api-reference/beta/api/voiceauthenticationmethodconfiguration-update.md | Documents callerIdNumber as an updatable property via PATCH. |
| api-reference/beta/api/voiceauthenticationmethodconfiguration-get.md | Updates the response example to include callerIdNumber. |
| "isOfficePhoneAllowed": "true", | ||
| "callerIdNumber": null |
FaithOmbongi
left a comment
There was a problem hiding this comment.
@trsadara - We don't accept substantial contributions from internal team members here, especially those involving schema changes. This is because many validations are not performed in this repo (privacy concerns), so we can't ensure the integrity of changes before merging. Please submit the PR in the private repository https://github.com/microsoftgraph/microsoft-graph-docs. If you encounter a 404 error, make sure to complete the Get started steps in https://aka.ms/msgraphcdk.
Summary
Unhides the
callerIdNumberproperty onvoiceAuthenticationMethodConfigurationin the beta API documentation. This property was previously hidden behind a private preview annotation in the AGS schema and is now being exposed publicly.What changed
Added the
callerIdNumberproperty (type:String) to:Resource type doc (
api-reference/beta/resources/voiceauthenticationmethodconfiguration.md):GET API doc (
api-reference/beta/api/voiceauthenticationmethodconfiguration-get.md):callerIdNumberto the response exampleUPDATE API doc (
api-reference/beta/api/voiceauthenticationmethodconfiguration-update.md):callerIdNumberto the request body properties tableRelated changes
callerIdNumberonvoiceAuthenticationMethodConfigurationinschema-Prod-beta.csdlby removingags:IsHiddenand the deprecated annotation.