docs: fix misleading getMongoClient() JSDoc#696
Open
hanhan761 wants to merge 1 commit into
Open
Conversation
docs: fix misleading getMongoClient() JSDoc The JSDoc claimed getMongoClient() is used by the query playground evaluator, but the playground worker has its own MongoClient in a separate worker_thread/V8 isolate. The sole caller is actually scanCollectionSchema which runs on the extension host main thread. Closes microsoft#643 @
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@
Summary
Fix the
getMongoClient()JSDoc which incorrectly stated the method is used by the query playground evaluator. The playground worker runs in its ownworker_threadwith a separateMongoClientinstance. The sole caller is actuallyscanCollectionSchemaon the extension host main thread.Issue
Fixes #643
@