Skip to content

feat: batch deletion of multiple connections#663

Closed
Copilot wants to merge 1 commit into
dev/tnaum/connection-multi-deletefrom
copilot/sub-pr-398
Closed

feat: batch deletion of multiple connections#663
Copilot wants to merge 1 commit into
dev/tnaum/connection-multi-deletefrom
copilot/sub-pr-398

Conversation

Copilot AI commented May 21, 2026

Copy link
Copy Markdown
Contributor

PR #398 accumulated 1552 commits and 683 "changed files" due to a merge commit (9527c415) that pulled in historical branches via a second parent. The actual diff against next is 2 files.

This PR documents the clean implementation and provides the force-push path to restore PR #398 to a 2-file diff.

Changes

  • removeConnection.ts — Accepts optional nodes?: DocumentDBClusterItem[] for tree-view multi-select; falls back to single node for backward compatibility

    • Pre-flight loop: checks all selected connections for running tasks before prompting
    • Confirmation message adapts: single name vs. Delete {count} connections?
    • Resilient deletion loop — continues on individual failure, logs each via ext.outputChannel.error
    • Telemetry: connectionsToDelete, connectionsDeleted, errorCount; last error captured in properties.error/errorMessage with a comment noting the intentional single-capture
    • Warns via ext.outputChannel.warn when invoked with no selection instead of silently returning
  • l10n/bundle.l10n.json — Five new strings: multi-delete confirmation, partial-failure summary, success summary, per-connection error, and empty-selection warning

Recovering PR #398

The branch dev/tnaum/connection-multi-delete needs a force-push to expose the clean 2-file diff:

git fetch origin
git checkout dev/tnaum/connection-multi-delete
git reset --hard origin/next
git cherry-pick 62d739b9        # the clean feature commit
git push --force-with-lease origin dev/tnaum/connection-multi-delete

Copilot AI commented May 21, 2026

Copy link
Copy Markdown
Contributor Author

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://api.github.com/user
    • Triggering command: /usr/bin/curl curl -s -H Authorization: ****** REDACTED 20.2/deps/uv/include /binding.o 20.2/deps/zlib Release/obj.targsh 20.2/deps/v8/inc-c -I ding.o.d ./Re�� )$/\1/p /binding.o es/.bin/sh -I che/node-gyp/20.-c -I che/node-gyp/20.20.2/deps/openssprettier-fix (http block)
    • Triggering command: /usr/bin/curl curl -v -H Authorization: ****** REDACTED printf '%s\n' 'cmd_Release/obj.target/cpu_features/deps/cpu_features/src/impl_aarch64_macos_or_inode /binding.o nfig/composer/vendor/bin/as ')); ns are selected -c es/os-dns-nativetsc -p . sed -e d -n 10 ./Release/.deps/Release/obj.target/cpu_features/deps/cpu_features/src/impl_mips_linux_or_androiddiff che/node-gyp/20.20.2/src arget/cpu_featursh che/node-gyp/20.-c p/bin/git che/node-gyp/20.20.2/deps/openssprettier-fix (http block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] Enhance connection removal feature with batch deletion support feat: batch deletion of multiple connections May 21, 2026
Copilot AI requested a review from tnaum-ms May 21, 2026 08:22
@tnaum-ms tnaum-ms closed this May 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants