feat: migration providers whitelisting + documentation#162
Merged
tnaum-ms merged 6 commits intoJun 16, 2025
Merged
Conversation
…e for plugins as we're still in the experimental phase
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces an experimental data migration framework for the DocumentDB extension along with enhanced API safeguards, documentation updates, and localization improvements.
- Refactored MigrationService to update VS Code context upon provider registration/unregistration.
- Updated the data migration command to improve authentication warnings and remove legacy code.
- Added a client whitelist to the API configuration in package.json and enhanced related documentation.
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/services/migrationServices.ts | Refactored provider registration/unregistration and added context updates for migration providers. |
| src/commands/chooseDataMigrationExtension/chooseDataMigrationExtension.ts | Updated authentication prompts and commented out unused add-migration-provider code for clarity. |
| package.json | Included a whitelist of registered clients and updated the context condition for migration providers. |
| l10n/bundle.l10n.json | Updated localization strings to reflect new authentication warning details. |
| docs/manual/how-to-construct-url.md | Updated connection string examples to use localhost for clarity. |
| docs/learn-more/index.md & docs/learn-more/data-migrations.md | Added new sections documenting the experimental data migrations feature. |
| docs/index.md | Updated index to reference the new data migrations section. |
| api/src/utils/getApi.ts | Introduced a type guard to validate the API configuration and ensure calling extensions are whitelisted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces experimental features for the DocumentDB extension in VS Code, focusing on a new data migration framework and enhanced API safeguards. It also includes minor updates to documentation, localization strings, and code cleanup. Below is a summary of the most important changes grouped by theme.
Experimental Data Migration Framework
docs/learn-more/data-migrations.md, docs/learn-more/data-migrations.mdR1-R92)package.jsonto include a whitelist of registered clients allowed to use the experimental API. (package.json, package.jsonR922-R927)API Safeguards and Validation
isValidPackageJson) to validate the DocumentDB API configuration inpackage.jsonand ensure calling extensions are whitelisted. (api/src/utils/getApi.ts, [1] [2]src/commands/chooseDataMigrationExtension/chooseDataMigrationExtension.ts, [1] [2]Documentation Updates
docs/index.md, [1];docs/learn-more/index.md, [2]localhostinstead of external clusters for clarity. (docs/manual/how-to-construct-url.md, docs/manual/how-to-construct-url.mdL87-R105)Codebase Enhancements
MigrationServiceto include methods for registering and unregistering migration providers, with automatic updates to VS Code context. (src/services/migrationServices.ts, [1] [2]src/commands/chooseDataMigrationExtension/chooseDataMigrationExtension.ts, [1] [2] [3]Localization Adjustments
l10n/bundle.l10n.json, [1] [2]