Fix 17 missing icons in the SVG sprite and the validation logic

[Rafael Staib (rstaib)]

Summary

Note: reordering mapping.json flips the canonical name for these 17 in the generated codiconsLibrary.ts (e.g. symbolVariable is now the definition, variable its alias). All existing names still resolve.

17 icons whose SVG file is named after a secondary alias were silently dropped from the generated SVG sprite.

The sprite generator located each icon's file via its primary alias (mapping.json aliases[0]). For these 17 icons, the file on disk is named after a different alias. For example, the file is symbol-variable.svg, but the codepoint's primary alias is variable, and no variable.svg exists. As a result, fs.existsSync failed and the entire codepoint (every one of its aliases) was excluded from the sprite.

The same primary-vs-filename mismatch meant metadata.json was keyed by names that don't match any SVG file, while the preview looks metadata up by filename.

check-metadata.js reported 100% coverage throughout, because it only validated the primary alias, so it never caught the gap.

Fixes #480

Affected icons (file name ← previous primary/metadata key)

SVG file	was keyed/ordered as
circle	circle-outline
desktop-download	clone
ellipsis	more
github	logo-github
go-to-file	symbol-reference
lock	gist-private
reply	mail-reply
repo-forked	gist-fork
sign-in	log-in
sign-out	log-out
star-empty	star
symbol-array	array
symbol-event	zap
symbol-namespace	symbol-module
symbol-variable	variable
sync	repo-sync
warning	alert

[Rafael Staib (rstaib)]

@microsoft-github-policy-service agree

[Muhammad Akbar (MAkbarZ)]

"cut" or "scissors" icon is also missing. I had to use "screen-cut" instead, but it doesn't look good.

[Rafael Staib (rstaib)]

Lee Murray (@mrleemurray) any chance to get this in? Let me know I can help in any way.

[Copilot]

🟡 Changes recommended

The renamed metadata entries violate the repository’s required alphabetical ordering.

Get a fresh assessment by requesting another Copilot review.

Pull request overview

Fixes SVG sprite generation and metadata validation for icons whose files use secondary aliases.

Changes:

• Resolves SVG sources from any mapped alias.
• Aligns canonical mappings and metadata with SVG filenames.
• Validates metadata against actual SVG files.

File summaries

File	Description
scripts/svg-sprite.js	Resolves backing SVGs across aliases.
scripts/check-metadata.js	Validates physical SVG filenames.
src/template/mapping.json	Promotes SVG filenames to primary aliases.
src/template/metadata.json	Rekeys metadata to SVG filenames.

Review details

• Files reviewed: 4/4 changed files
• Comments generated: 1
• Review effort level: Balanced

---

💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

Copilot review overview

🟡 Changes recommended

Missing source SVGs still produce a successful but incomplete sprite build.

Get a fresh assessment by requesting another Copilot review.

Review effort: Balanced
Findings: 1

Open (1)

• Fail build when mapped codepoints lack backing SVGs · New

Resolved since last review (1)

• The renamed entries were left at their old keys' positions, so this file is no longer…

[Copilot]

Copilot review overview

🟢 Approval recommended

The icon mappings, SVG files, and metadata are complete and mutually consistent.

Review effort: Balanced
Findings: None

Resolved since last review (1)

• Fail build when mapped codepoints lack backing SVGs

[Lee Murray (mrleemurray)]

Rafael Staib (@rstaib) feel free to merge :)