Skip to content

CI/CD - Clean up image builds, remove cuda 12.8/12.4/12.2 and add cuda13.0 merge#819

Merged
polarG merged 3 commits into
mainfrom
dev/hongtaozhang/cleanup-build-images
Jun 3, 2026
Merged

CI/CD - Clean up image builds, remove cuda 12.8/12.4/12.2 and add cuda13.0 merge#819
polarG merged 3 commits into
mainfrom
dev/hongtaozhang/cleanup-build-images

Conversation

@polarG

@polarG polarG commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

Description

Clean up the Docker image build matrix in build-image.yml.

Changes

  • Remove the docker-build entries for cuda 12.8, 12.4, and 12.2.
  • Remove the corresponding cuda12.8 docker-merge entry and add a cuda13.0 merge entry (merging amd64 + arm64), alongside the existing cuda12.9 merge.
  • Add fail-fast: false to the docker-merge matrix so a failed merge for one CUDA version does not cancel the other merge legs. The job keeps if: ${{ !cancelled() }} so merges still run as long as the workflow was not cancelled.

Notes

  • The docker-merge condition is intentionally !cancelled() (not success()): the docker-build matrix uses fail-fast: false because the self-hosted ROCm build can fail transiently, and we don't want a flaky ROCm build to block merging the CUDA images.

Copilot AI review requested due to automatic review settings June 2, 2026 23:24
@polarG polarG requested a review from a team as a code owner June 2, 2026 23:24

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the GitHub Actions Docker image build workflow to simplify the CUDA build/merge matrix by removing older CUDA versions and adding a multi-arch merge for CUDA 13.0.

Changes:

  • Removed cuda12.8 image builds (arm64/amd64) and removed cuda12.4 / cuda12.2 image builds.
  • Added a docker-merge matrix entry to publish a merged multi-arch cuda13.0 tag.
  • Changed the docker-merge job condition from running when not cancelled to running only on overall success.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/build-image.yml Outdated
Copilot AI review requested due to automatic review settings June 2, 2026 23:33

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Comment thread .github/workflows/build-image.yml
@codecov

codecov Bot commented Jun 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.02%. Comparing base (e271df3) to head (3ae7719).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #819   +/-   ##
=======================================
  Coverage   86.02%   86.02%           
=======================================
  Files         103      103           
  Lines        7950     7950           
=======================================
  Hits         6839     6839           
  Misses       1111     1111           
Flag Coverage Δ
cpu-python3.10-unit-test 70.88% <ø> (ø)
cpu-python3.12-unit-test 70.88% <ø> (ø)
cpu-python3.7-unit-test 70.31% <ø> (ø)
cuda-unit-test 83.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@polarG polarG enabled auto-merge (squash) June 2, 2026 23:45
@polarG polarG self-assigned this Jun 3, 2026
@polarG polarG added the CI/CD Continuous integration or deployment label Jun 3, 2026
@polarG polarG merged commit 67298ae into main Jun 3, 2026
21 of 23 checks passed
@polarG polarG deleted the dev/hongtaozhang/cleanup-build-images branch June 3, 2026 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI/CD Continuous integration or deployment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants