CI/CD - Clean up image builds, remove cuda 12.8/12.4/12.2 and add cuda13.0 merge#819
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the GitHub Actions Docker image build workflow to simplify the CUDA build/merge matrix by removing older CUDA versions and adding a multi-arch merge for CUDA 13.0.
Changes:
- Removed
cuda12.8image builds (arm64/amd64) and removedcuda12.4/cuda12.2image builds. - Added a
docker-mergematrix entry to publish a merged multi-archcuda13.0tag. - Changed the
docker-mergejob condition from running when not cancelled to running only on overall success.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
added 2 commits
June 2, 2026 23:31
…lse so CUDA merges stay independent of flaky ROCm builds
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #819 +/- ##
=======================================
Coverage 86.02% 86.02%
=======================================
Files 103 103
Lines 7950 7950
=======================================
Hits 6839 6839
Misses 1111 1111
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
guoshzhao
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Clean up the Docker image build matrix in
build-image.yml.Changes
docker-buildentries for cuda 12.8, 12.4, and 12.2.docker-mergeentry and add a cuda13.0 merge entry (mergingamd64+arm64), alongside the existing cuda12.9 merge.fail-fast: falseto thedocker-mergematrix so a failed merge for one CUDA version does not cancel the other merge legs. The job keepsif: ${{ !cancelled() }}so merges still run as long as the workflow was not cancelled.Notes
docker-mergecondition is intentionally!cancelled()(notsuccess()): thedocker-buildmatrix usesfail-fast: falsebecause the self-hosted ROCm build can fail transiently, and we don't want a flaky ROCm build to block merging the CUDA images.