Bugfix: deepseek benchmark names conflict#725
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release/0.12 #725 +/- ##
=============================================
Coverage 86.47% 86.47%
=============================================
Files 102 102
Lines 7541 7541
=============================================
Hits 6521 6521
Misses 1020 1020
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
yukirora
approved these changes
Jul 31, 2025
guoshzhao
approved these changes
Jul 31, 2025
polarG
added a commit
that referenced
this pull request
Aug 12, 2025
Summary Deepseek currently registers two benchmarks using the same identifier, causing a naming conflict. Change Rename each benchmark so that both have unique, descriptive names. Co-authored-by: Hongtao Zhang <hongtaozhang@microsoft.com>
polarG
added a commit
that referenced
this pull request
Aug 12, 2025
**Description** Cherry-pick bug fixes from v0.12.0 to main. **Major Revisions** * #725 * #727 * #728 Co-authored-by: Hongtao Zhang <hongtaozhang@microsoft.com> Co-authored-by: Yifan Xiong <yixio@microsoft.com> Co-authored-by: Guoshuai Zhao <guzhao@microsoft.com> --------- Co-authored-by: Hongtao Zhang <hongtaozhang@microsoft.com>
Aishwarya-Tonpe
pushed a commit
that referenced
this pull request
Aug 16, 2025
**Description** Cherry-pick bug fixes from v0.12.0 to main. **Major Revisions** * #725 * #727 * #728 Co-authored-by: Hongtao Zhang <hongtaozhang@microsoft.com> Co-authored-by: Yifan Xiong <yixio@microsoft.com> Co-authored-by: Guoshuai Zhao <guzhao@microsoft.com> --------- Co-authored-by: Hongtao Zhang <hongtaozhang@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Deepseek currently registers two benchmarks using the same identifier, causing a naming conflict.
Change
Rename each benchmark so that both have unique, descriptive names.