Skip to content

Bugfix: deepseek benchmark names conflict.#722

Closed
polarG wants to merge 1 commit into
release/0.12from
release/0.12-fix-deepseek-name-conflict
Closed

Bugfix: deepseek benchmark names conflict.#722
polarG wants to merge 1 commit into
release/0.12from
release/0.12-fix-deepseek-name-conflict

Conversation

@polarG

@polarG polarG commented Jul 10, 2025

Copy link
Copy Markdown
Contributor

Summary
Deepseek currently registers two benchmarks using the same identifier, causing a naming conflict.

Change
Rename each benchmark so that both have unique, descriptive names.

@polarG polarG requested a review from a team as a code owner July 10, 2025 23:50
@polarG polarG requested review from abuccts and guoshzhao July 10, 2025 23:50
@polarG polarG added the bug Something isn't working label Jul 10, 2025
@codecov

codecov Bot commented Jul 10, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.47%. Comparing base (44e35cd) to head (67fbc58).

Additional details and impacted files
@@              Coverage Diff              @@
##           release/0.12     #722   +/-   ##
=============================================
  Coverage         86.47%   86.47%           
=============================================
  Files               102      102           
  Lines              7541     7541           
=============================================
  Hits               6521     6521           
  Misses             1020     1020           
Flag Coverage Δ
cpu-python3.10-unit-test 71.59% <ø> (ø)
cpu-python3.12-unit-test 71.59% <ø> (ø)
cpu-python3.7-unit-test 70.65% <ø> (ø)
cuda-unit-test 83.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@polarG polarG requested a review from yukirora July 11, 2025 00:01

@abuccts abuccts left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

release/* branch is protected, please rename your develop branch

@polarG polarG enabled auto-merge (squash) July 11, 2025 20:44
@polarG polarG changed the title Fix deepseek benchmark names conflict. Bugfix: deepseek benchmark names conflict. Jul 11, 2025
@polarG

polarG commented Jul 21, 2025

Copy link
Copy Markdown
Contributor Author

Close this PR to correct the source branch.

@polarG polarG closed this Jul 21, 2025
auto-merge was automatically disabled July 21, 2025 22:51

Pull request was closed

@abuccts abuccts deleted the release/0.12-fix-deepseek-name-conflict branch July 30, 2025 21:35
@polarG polarG restored the release/0.12-fix-deepseek-name-conflict branch July 30, 2025 23:27
@guoshzhao guoshzhao deleted the release/0.12-fix-deepseek-name-conflict branch July 30, 2025 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants