Skip to content

Commit 2471d19

Browse files
Fix setting.jsons (#429)
1 parent 0e69a58 commit 2471d19

8 files changed

Lines changed: 12 additions & 13 deletions

File tree

assistants/skill-assistant/.vscode/settings.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
"python.analysis.fixAll": ["source.unusedImports"],
2626
"python.analysis.inlayHints.functionReturnTypes": true,
2727
"python.analysis.typeCheckingMode": "standard",
28-
"python.defaultInterpreterPath": "${workspaceFolder}/.venv/bin/python",
28+
"python.defaultInterpreterPath": "${workspaceFolder}/.venv",
2929
"python.testing.pytestEnabled": false,
3030
"[python]": {
3131
"editor.defaultFormatter": "charliermarsh.ruff",

libraries/python/assistant-drive/.vscode/settings.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
"python.analysis.fixAll": ["source.unusedImports"],
2525
"python.analysis.inlayHints.functionReturnTypes": true,
2626
"python.analysis.typeCheckingMode": "standard",
27-
"python.defaultInterpreterPath": "${workspaceFolder}/.venv/bin/python",
27+
"python.defaultInterpreterPath": "${workspaceFolder}/.venv",
2828
"python.testing.cwd": "${workspaceFolder}",
2929
"python.testing.pytestArgs": ["--color", "yes"],
3030
"python.testing.pytestEnabled": true,

libraries/python/events/.vscode/settings.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
"python.analysis.fixAll": ["source.unusedImports"],
2020
"python.analysis.inlayHints.functionReturnTypes": true,
2121
"python.analysis.typeCheckingMode": "standard",
22-
"python.defaultInterpreterPath": "${workspaceFolder}/.venv/bin/python",
22+
"python.defaultInterpreterPath": "${workspaceFolder}/.venv",
2323
"python.testing.cwd": "${workspaceFolder}",
2424
"search.exclude": {
2525
"**/.venv": true,

libraries/python/guided-conversation/.vscode/settings.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
"python.analysis.fixAll": ["source.unusedImports"],
2525
"python.analysis.inlayHints.functionReturnTypes": true,
2626
"python.analysis.typeCheckingMode": "standard",
27-
"python.defaultInterpreterPath": "${workspaceFolder}/.venv/bin/python",
27+
"python.defaultInterpreterPath": "${workspaceFolder}/.venv",
2828
"python.testing.cwd": "${workspaceFolder}",
2929
"search.exclude": {
3030
"**/.venv": true,

libraries/python/skills/skill-library/.vscode/settings.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
"python.analysis.fixAll": ["source.unusedImports"],
2020
"python.analysis.inlayHints.functionReturnTypes": true,
2121
"python.analysis.typeCheckingMode": "standard",
22-
"python.defaultInterpreterPath": "${workspaceFolder}/.venv/bin/python",
22+
"python.defaultInterpreterPath": "${workspaceFolder}/.venv",
2323
"python.testing.pytestEnabled": true,
2424
"search.exclude": {
2525
"**/.venv": true,

mcp-servers/mcp-server-filesystem-edit/.vscode/settings.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,8 @@
6666
"pdflatex",
6767
"toplevel",
6868
"unblockified",
69-
"unblockify"
69+
"unblockify",
70+
"Xworks"
7071
],
7172
// Python testing configuration
7273
"python.testing.pytestEnabled": true,

mcp-servers/mcp-server-filesystem-edit/mcp_server_filesystem_edit/config.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,10 @@
11
# Copyright (c) Microsoft. All rights reserved.
22

33
import os
4+
import sys
5+
from typing import Annotated
46

7+
from pydantic import Field
58
from pydantic_settings import BaseSettings
69

710
log_level = os.environ.get("LOG_LEVEL", "INFO")
@@ -18,8 +21,8 @@ class Settings(BaseSettings):
1821
log_level: str = log_level
1922
allowed_directories: list[str] = []
2023
include_hidden_paths: bool = False
21-
office_support_enabled: bool = False
2224
pdflatex_enabled: bool = False
25+
office_support_enabled: Annotated[bool, Field(default_factory=lambda: sys.platform == "win32")] = False
2326

2427
# LLM and prompt related settings
2528
comment_author: str = "Feedback Tool"

mcp-servers/mcp-server-filesystem-edit/mcp_server_filesystem_edit/start.py

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
from mcp_server_filesystem_edit import settings
88
from mcp_server_filesystem_edit.server import create_mcp_server
99

10-
logger = logging.getLogger("mcp_server_filesystem")
10+
logger = logging.getLogger(__name__)
1111

1212

1313
def main() -> None:
@@ -37,11 +37,6 @@ def main() -> None:
3737
# settings.allowed_directories = args.allowed_directories
3838
logger.info(f"Using allowed_directories from command line: {settings.allowed_directories}")
3939

40-
# Enabled Office integration by default if the user is on Windows x64
41-
if sys.platform == "win32":
42-
settings.office_support_enabled = True
43-
logger.info("Windows x64 platform detected, Office support enabled by default.")
44-
4540
# Set pdflatex_enabled based on command line argument
4641
settings.pdflatex_enabled = args.enable_pdflatex
4742
logger.info(f"LaTeX compilation support: {'enabled' if settings.pdflatex_enabled else 'disabled'}")

0 commit comments

Comments
 (0)