Minor Filesystem MCP Updates (#428)

Author: DavidKoleczek

mcp-servers/mcp-server-filesystem-edit/README.md

@@ -1,6 +1,7 @@
 # Filesystem Edit MCP Server
 
-Allows for robust editing Markdown and LaTeX files.
+Allows for robust editing of Markdown, Office, and LaTeX files.
+Your system and configuration will determine which are supported. By default working with Markdown (`.md`) files is always enabled
 
 This is a [Model Context Protocol](https://github.com/modelcontextprotocol) (MCP) server project.
 
@@ -37,6 +38,12 @@ http://127.0.0.1:25567/sse
 ```
 
 
+### Optional Features
+- If you have pdflatex installed on your system and you would like `edit_file` to automatically compile LaTeX files for you,
+can provide the argument `--enable-pdflatex` when starting the server.
+- If the system is Windows, it will automatically you have Office apps installed and will use them to edit `.docx` files and also view `.xlsx` files.
+
+
 ### Setting Working Directory
 The server uses a single working directory for security purposes. There are two ways to configure them:
 
@@ -51,22 +58,24 @@ The server uses a single working directory for security purposes. There are two
 
 ### `view_file(path)`
 - Reads the content of the file at the given path.
-
-### `edit_file(path, task)`
+- NOTE: Currently only certain common file types are supported.
+- For viewing:
+  - Directly can view: `.md`, `.csv`, `.tex`
+  - Can be viewed through an office app, only on Windows: `.docx`, `.xlsx` (first worksheet)
+- These file extensions can be edited:
+  - Directly on the filesystem: `.md`, `.tex`
+  - Through an office app, only on Windows: `.docx`
+  - If you have `pdflatex` installed and provide the `--enable-pdflatex` argument, you can also automatically compile LaTeX files.
+
+### `edit_file(path, task: str)`
 - Edits the file at the given path with the provided content according to the task.
 - Uses sampling to understand things like conversation history and attachments from the client.
-- If the file extension is `.md` or `.tex`, special handling is applied.
 - All other file types will return an error.
 - If `enable-pdflatex` is set, it will compile the LaTeX file using pdflatex and return the output.
 
-### `add_comments(path, comments)`
+### `add_comments(path, only_analyze: bool)`
 - Reads the file at the given path, adds comments to the content, and returns suggestions on what to do next.
-- Special handling is applied for `.md` and `.tex` files. All other file types will return an error.
-
-
-### Optional Features
-- If you have pdflatex installed on your system and you would like `edit_file` to automatically compile LaTeX files for you,
-can provide the argument `--enable-pdflatex` when starting the server.
+- If only_analyze is set to true, it will only analyze the comments in the current file and return hints on what to do next without modifying the file.
 
 
 ## Client Configuration

mcp-servers/mcp-server-filesystem-edit/mcp_server_filesystem_edit/server.py

@@ -1,5 +1,6 @@
 # Copyright (c) Microsoft. All rights reserved.
 
+import logging
 import sys
 from pathlib import Path
 
@@ -20,6 +21,8 @@
 # Set the name of the MCP server
 server_name = "Filesystem Edit MCP Server"
 
+logger = logging.getLogger("mcp_server_filesystem")
+
 
 VIEW_BY_FILE_EXTENSIONS = [".md", ".tex", ".csv"]
 VIEW_CUSTOM_EXTENSIONS = [".docx", ".xlsx", ".csv"]
@@ -44,9 +47,13 @@ async def get_allowed_directory(ctx: Context) -> Path:
         else:
             roots = [Path(root.uri.path).resolve() for root in list_roots_result.roots if root.uri.path]
 
-        roots = [root for root in roots if root.is_dir()]
+        roots = [root for root in roots if root.is_dir() or (not root.exists() and not root.suffix)]
         if roots:
-            return roots[0]
+            first_root = roots[0]
+            if not first_root.exists():
+                logger.info(f"Creating directory from first root since it does not exist yet: {first_root}")
+                first_root.mkdir(parents=True, exist_ok=True)
+            return first_root
 
     raise ValueError("No allowed_directories have been configured and no roots have been set.")