Skip to content

fix(hubble): surface controller-runtime manager start failures#2399

Open
slariviere wants to merge 3 commits into
microsoft:mainfrom
slariviere:fix/hubble-surface-manager-start-failure
Open

fix(hubble): surface controller-runtime manager start failures#2399
slariviere wants to merge 3 commits into
microsoft:mainfrom
slariviere:fix/hubble-surface-manager-start-failure

Conversation

@slariviere

Copy link
Copy Markdown
Contributor

Description

Wrap the controller-runtime manager's start call so that any returned error or an unexpected clean return is logged and triggers a hive shutdown instead of being silently discarded by the worker pool.

Related Issue

If this pull request is related to any issue, please mention it here. Additionally, make sure that the issue is assigned to you before submitting this pull request.

Checklist

  • I have read the contributing documentation.
  • I signed and signed-off the commits (git commit -S -s ...). See this documentation on signing commits.
  • I have correctly attributed the author(s) of the code.
  • I have tested the changes locally.
  • I have followed the project's style guidelines.
  • I have updated the documentation, if necessary.
  • I have added tests, if applicable.

Screenshots (if applicable) or Testing Completed

In my case, a port conflict was preventing the controller-runtime manager from starting:

ts=2026-06-02T13:35:23.949Z level=error caller=hubble/daemon_linux.go:86 msg="controller-runtime manager exited with error; node reconciler is no longer running" module=agent.control-plane.daemon error="failed to start metrics server: failed to create listener: listen tcp :18080: bind: address already in use" stacktrace="log/slog.(*Logger).Error\n\t/usr/local/go/src/log/slog/logger.go:229\ngithub.com/microsoft/retina/cmd/hubble.init.func4.1.1\n\t/go/src/github.com/microsoft/retina/cmd/hubble/daemon_linux.go:86\ngithub.com/cilium/workerpool.(*WorkerPool).run.func1\n\t/go/pkg/mod/github.com/cilium/workerpool@v1.4.0/workerpool.go:269"

Additional Notes

Add any additional notes or context about the pull request here.


Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.

Wrap the controller-runtime manager's Start call so a returned error,
or an unexpected clean return, is logged and triggers a hive shutdown
instead of being silently discarded by the workerpool.

Signed-off-by: Sébastien Larivière <sebastien.lariviere@goto.com>
@slariviere slariviere requested a review from a team as a code owner June 2, 2026 16:20
@slariviere slariviere requested review from nairashu and vipul-21 June 2, 2026 16:20
@slariviere slariviere force-pushed the fix/hubble-surface-manager-start-failure branch 2 times, most recently from ee50d44 to 98546cc Compare June 2, 2026 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant