fix(hubble): surface controller-runtime manager start failures#2399
Open
slariviere wants to merge 3 commits into
Open
fix(hubble): surface controller-runtime manager start failures#2399slariviere wants to merge 3 commits into
slariviere wants to merge 3 commits into
Conversation
Wrap the controller-runtime manager's Start call so a returned error, or an unexpected clean return, is logged and triggers a hive shutdown instead of being silently discarded by the workerpool. Signed-off-by: Sébastien Larivière <sebastien.lariviere@goto.com>
ee50d44 to
98546cc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Wrap the controller-runtime manager's start call so that any returned error or an unexpected clean return is logged and triggers a hive shutdown instead of being silently discarded by the worker pool.
Related Issue
If this pull request is related to any issue, please mention it here. Additionally, make sure that the issue is assigned to you before submitting this pull request.
Checklist
git commit -S -s ...). See this documentation on signing commits.Screenshots (if applicable) or Testing Completed
In my case, a port conflict was preventing the controller-runtime manager from starting:
Additional Notes
Add any additional notes or context about the pull request here.
Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.