possibly speed up physics by extracting variable decls for loops?#1361
Draft
jwunderl wants to merge 1 commit into
Draft
possibly speed up physics by extracting variable decls for loops?#1361jwunderl wants to merge 1 commit into
jwunderl wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned on stream pulling out decls from hot loops can possibly speed things up at no real cost -- but still have to check if this is a case where it matters & speeds things up. IIRC we have some level of const inlining that may negate the benefits or even cause this to be slower, but worth a check / need to test on hw