fix(tracing): do not hang on unresponsive page when capturing snapshots - #42919
Conversation
| await page.goto(server.EMPTY_PAGE); | ||
| await page.evaluate(() => { | ||
| setTimeout(() => { | ||
| while (true) {} |
There was a problem hiding this comment.
Nothing works on these pages, this test and change do not make sense.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Test results for "MCP"3 failed 8735 passed, 1480 skipped Merge workflow run. |
Test results for "tests 1"4 flaky52302 passed, 1241 skipped Merge workflow run. |
|
Hi, I'm the Playwright bot and I took a first look at the CI failures here. 🟢 The failures look like pre-existing flakes, not this PRThe latest "tests 1" run only has flaky tests, which retries rescued. The three MCP failures are all known flaky tests that also fail on DetailsI checked the latest reports on head Pre-existing flake / infra
Triaged by the Playwright bot - agent run |
aec6432
into
microsoft:main
Summary
_captureSnapshotagainstprogressso a busy page cannot block before/after hooks forever.await-must-use-progresslint rule see through optional chaining, which hid this case.react-hooks/exhaustive-depswarning in trace viewer workbench.Fixes #42903