Repository navigation
fix(webkit): allow service worker navigation while offline - #42894
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
5a973e3 to
ba8797a
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
let's drop this tests and keep coverage only for the functionality that is being fixed
offline emulation rejects navigation even when a service worker supplies the response apply configured offline state when page targets are initialized cover service worker responses on existing and newly opened pages
ba8797a to
02e243a
Compare
Test results for "tests 1"1 failed 4 flaky52516 passed, 1270 skipped Merge workflow run. |
🟢 The failure is pre-existing CI infra noiseHi, I'm the Playwright bot and I took a first look. The PR is clear: DetailsPre-existing flake / infra
The four retry-rescued tests in the report are flaky rather than failed, so they do not affect this verdict. Triaged by the Playwright bot - agent run |
Test results for "MCP"2 failed 9013 passed, 1489 skipped Merge workflow run. |
🟢 Both failures are pre-existing flakes — the PR is clearHi, I'm the Playwright bot and I took a first look at the latest MCP failures. Both tests have failed on unrelated SHAs on the same Windows/browser bots, while this PR only changes WebKit offline initialization and its library coverage. DetailsThe latest MCP report has two failures. Neither test exercises WebKit, offline emulation, service workers, or a helper changed by this PR. Pre-existing flake / infra
The required results-database refresh was attempted twice, but GitHub's repository-artifacts API returned HTTP 500. The historical counts above come from recent Playwright bot triages backed by that database; the linked unrelated runs establish the same-test flake history required for this verdict. Triaged by the Playwright bot - agent run |
ea75b9f
into
microsoft:main
offline emulation rejects navigation even when a service worker supplies the response
apply configured offline state when page targets are initialized
cover service worker responses, context isolation, and reopening pages
fixes #42775