fix(clock): make Temporal.Now follow page.clock - #42838
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Test results for "tests 1"12 flaky52057 passed, 1252 skipped Merge workflow run. |
Test results for "MCP"6 failed 8686 passed, 1474 skipped Merge workflow run. |
🟢 All six failures are pre-existing flakes on
|
| test | failed / total runs on this bot | other PRs it failed on | error signature |
|---|---|---|---|
mcp/annotate.spec.ts:446 › should switch screencast to -s session on show --annotate |
74 / 699 | #42186, #42785, #42751, #42736, #42723, … (33 distinct) | toHaveAccessibleName on the session region times out |
mcp/cli-session.spec.ts:54 › idle timeout shuts the session down |
45 / 144 | #42843, #42834, #42833, #42832, #42784, … (25 distinct) | expected "(no browsers)", got a still-open firefox browser |
mcp/cli-core.spec.ts:276 › click button with role locator |
8 / 701 | #42787, #42744, #42431, #42395, #42239 | expect(received).toBeTruthy() → undefined |
mcp/cli-core.spec.ts:115 › hover |
8 / 701 | #42513, #42395, #42301 | expected "mouse move 50 50", got "" |
mcp/http.spec.ts:145 › http transport browser sigint |
9 / 701 | #42833, #42663, #42550, #42383, #42275 | missing "close browser" in the event tally |
mcp/idle-timeout.spec.ts:19 › closes the browser after the idle timeout and relaunches it on the next call |
5 / 169 | #42785, #42760, #42758, #42718 | snapshot: undefined instead of "Hello, world!" |
Each error message here matches the one the run on this PR produced, so it's the same failure mode, not a coincidence of name. cli-session.spec.ts:54 at a 31% fail rate on this bot is the loudest — that one looks worth a separate look independent of this PR.
The whole mcp-windows-latest-firefox bot is the common factor: the same MCP tests are green on mcp-ubuntu-latest-firefox and mcp-macos-latest-firefox (1–2 failures in ~710 runs each), which fits a slow-Windows timing problem in session teardown rather than anything in the diff.
Not triaged
The 12 entries in the "tests 1" report are flaky (passed on retry), not failures — library/video.spec.ts screencast, browsercontext-cookies-third-party.spec.ts, ui-mode-trace.spec.ts, the package-installation tests. None go near the clock.
I'm a first pass, not the final word — a re-run should confirm, and I'd expect it green.
Triaged by the Playwright bot - agent run
0facd92
into
microsoft:main
Summary
page.clockfakedDate, timers,performanceandIntl.DateTimeFormat, butTemporal.Nowkept reading the host clock.Temporaland override the clock-readingTemporal.Nowmethods (instant,zonedDateTimeISO,plainDateTimeISO,plainDateISO,plainTimeISO);timeZoneId()and the rest ofTemporalstay native.Fixes #42830