fix(dialog): handle auto-dismiss races - #42828
Merged
Merged
Conversation
Contributor
Author
|
@microsoft-github-policy-service agree |
Yury Semikhatsky (yury-s)
approved these changes
Sep 22, 2026
Contributor
Test results for "tests 1"5 flaky52020 passed, 1250 skipped Merge workflow run. |
Contributor
Test results for "MCP"8692 passed, 1474 skipped Merge workflow run. |
|
Thanks for this fix. We hit the same race in production: a page dialog opened while two CDP clients were connected, the auto-dismiss rejected, and the unhandled rejection crashed the Node process. We work around it by answering dialogs ourselves on every client we connect. That still leaves a short window between a client connecting and its listener being in place. Could this go into a 1.63.x patch release? If not, we will wait for 1.64.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #42827