fix(mcp): report a dialog opened during navigation instead of timing out - #42822
Open
AbNoZ&v02 (Abnoz01) wants to merge 1 commit into
Open
AbNoZ&v02 (Abnoz01) wants to merge 1 commit into
AbNoZ&v02 (Abnoz01) wants to merge 1 commit into
Conversation
A dialog opened while the page loads blocks domcontentloaded, so browser_navigate waited for the whole navigation timeout before failing. Race the navigation against a new modal state and return as soon as the dialog shows up, the same way actions do. Fixes microsoft#42817
|
AbNoZ&v02 (@Abnoz01) please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
domcontentloaded, sobrowser_navigateblocked for the full navigation timeout (60s by default) and then failed with aTimeoutError, only exposing the modal state afterwards.page.gotoagainst a newly appearing modal state and return as soon as the dialog shows up, so the response reports it andbrowser_handle_dialogcan continue, matching how actions already behave. Add a test.Fixes #42817